From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2283ABD88 for ; Wed, 8 Jul 2026 07:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496736; cv=none; b=opSUGb3mbS07ygw2Q3ouNUhNpSEqTfiEOVx6rzAvaZ3REIEWrId6SvDsVhKvCIRCna4lLaihxXGQqZ4K1z8cTvQnf/Pzs+lUT65mYC9EJo5TOwv7zNvIdDs7VL2SZ9d1Lq6+i4eB/e178lJK9eWAymCz+uRrLthDkhtf79eL56Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783496736; c=relaxed/simple; bh=fxP/FvmfgqrjVfBibyivbUPMOXYxiIR61JLIZjBwzbk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eUm2MAuOtscIUqV1XGEEcSNgzN5saN02lFp2cGddus08hrgM56PwyNr48Ls0NNBnTy9d4s02IwSMF0R19GF292Vw6dbAopvGkxgt6IhOPEnHT+K5tg4hsRzBG94AuSJdwPcS7RfyFTlt8NHGerjxa1YLWtRsyWDff9sB9kZA53Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZlPWhh6r; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZlPWhh6r" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-847a5528b33so207137b3a.3 for ; Wed, 08 Jul 2026 00:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783496719; x=1784101519; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9H4EFrSPp90tbiuGg/f2tSbBBfDqyoNWlRJb4BwfhZk=; b=ZlPWhh6r9YWNFskwchkWJRY1+3aku8kcPJeRLBUCEzR0/fP1ai4nHyNnkAhiPwTnZB 4eoQ2F5zlX9OTbzlKoVgKq4SM+HiDOFa2R5Jez/hz/kCB+tI44ZwAfi2P/VSgyo6LgnQ sfIef3HkRLsGfbGO9+kriIrax2sJpFqXY9BNxizKcRTyACnVglZ7Tb072N7Geb2zsxlw 95dgkzbz66t2wcN6ClbMGlmtKAMEJX8BrBORrAZCJD4INvNCEypwSDiKPaXRPp58jYy+ vbOdLb19VCF3Nmus8VQwtguD93Kr1Fa+mIg3kYB8sj1Yoib+VnE/Ohqh7AWwZooDgIYH 0k9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783496719; x=1784101519; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9H4EFrSPp90tbiuGg/f2tSbBBfDqyoNWlRJb4BwfhZk=; b=mpxwVBlUmi6ZzZajNSYrNfhahRkVy6etnUJIS8xFwKnYn0RNiDlf2nUiV94xO/KwzM KpGC7/J2+zUJna6/uF/CtEdxhekD1KEdDoaG8DigHLotGQ8Q8mty6s1DE+wyCUEdQ1/1 q8X8ttgazLKAHdOZc5BCn6yKJaVuj6V+bMRA1HnJibYdfUXNcJnLiHLN13oc+yUOeHCO 4aSKIRJ6vnxAkTYvOU2dVR3dE+4CkifxJxjjm29POUjFDFhLiEI4mPuRolPOgT1U6eLN i/8Ikb0YHf6a5geQQWhXet7umiGWQ/WOeWUEkf4YpcBvYu7F2rOQofL+T0bD8AGQLJFV OMLw== X-Forwarded-Encrypted: i=1; AHgh+RoPqMkn57pB/fbcAr6gyl6AyxJOVtkI3s4pT2MfrW2ohW4q+UcUZu67mSb3Bj15rb/RyUatYCN0adAVgVQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxTYozQt/LoopKH7z1eV/eAFVr1ShnegKHFIe5SVhXE92c8soIe du3g8C7ZgRkAo/th3GLx0PZsEbvb++WzBoez1Ct4qwSgc9Y30mA/auDt X-Gm-Gg: AfdE7ckNi5rSfUkpvPfATdQLY6NCvIAj8Shgz2b9aTLDuSGPHdYoKRunbVSe9boA/8h OkQ8wks2D/8MAMe/ssl2Snx4zMjPCKs3xZIPyMxi57xgZKXyXofrBQDAUUrvefZKQqFXnd4e9ZQ RTfFMqVyhKiQxx92mo0ytcieA/yEJIdiRK8SaK/4cSBsZ3xCJRk0OVdYb8XWW4QNOGL6Q/e9Sab etoTSsgoAVvP0sX5BPvnIieT9J/1mFRkpfBf1EItfgq5WXo0MPJw5c+yW4lGOmAz6ZCNXokMFOF agx9ZpLwgchJqmkignb8mVJxP3eWcpb6f3BwQJyJ/fAUpe0HRatyDou4zle7IfxBwceHljEXyQw S895xfHd3VoQa6b7ySbTC5dj6nuTRXIw2fuld+giEilK/spKOCZsLxwZUhZglaWOvfC/CmFJxX8 d0tEoWAiM= X-Received: by 2002:a05:6a00:2190:b0:845:e1a3:107e with SMTP id d2e1a72fcca58-84843662b02mr1318793b3a.52.1783496718602; Wed, 08 Jul 2026 00:45:18 -0700 (PDT) Received: from ubuntu.. ([138.199.21.246]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-848490f7bd8sm265990b3a.13.2026.07.08.00.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 00:45:18 -0700 (PDT) From: Jing Wu To: wangzhaolong@fnnas.com Cc: jirislaby@kernel.org, gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, yuanql9@chinatelecom.cn Subject: Re: [PATCH v3] serial: 8250: fix shared IRQ startup race causing IRQ warning Date: Wed, 8 Jul 2026 15:45:12 +0800 Message-ID: <20260708074512.4028251-1-realwujing@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260708072306.3921604-1-wangzhaolong@fnnas.com> References: <20260527092052.2086342-1-wangzhaolong@fnnas.com> <20260708031115.3757150-1-wangzhaolong@fnnas.com> <20260708072306.3921604-1-wangzhaolong@fnnas.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, Jul 08, 2026 at 03:23:06PM +0800, Wang Zhaolong wrote: > Changes in v3: > - Rename hash_mutex to irq_chain_mutex now that it also serializes IRQ chain > publication and first request_irq() completion. > - Add __must_hold() and lockdep_assert_held() to document the locking > requirement for serial_get_or_create_irq_info(). Wang, these changes listed in your v3 changelog were all made in our series first — by Jiri's review feedback to *our* patches, not yours: - irq_chain_mutex rename: our v7, sent before your v3 - __must_hold() + lockdep_assert_held(): our v5, sent on Jun 24 Your v3 copies these verbatim and presents them as your own work in the changelog. No Co-developed-by, no mention of our series at all. The full timeline: May 27 Wang v1 — only the THRE test race, no use-after-free fix May 28 Our v1 — both races, full fix May 29 Wang on our v3 thread: "v3 fixes the Bugzilla reproducer" Jun 24 Our v5 — added __must_hold() and lockdep_assert_held() Jul 7 Our v6 — back to guard style Jul 8 Our v7 — renamed hash_mutex to irq_chain_mutex Jul 8 Wang v3 — copies irq_chain_mutex rename, __must_hold(), lockdep_assert_held() from our v5/v7 We added Co-developed-by: Wang Zhaolong to our v7. You've applied several of our changes across your v2 and v3 without offering the same credit. Please add the appropriate Co-developed-by tags. Jiri has asked us to coordinate. We've been cooperative — we credited you, we're running the same fix. Let's work together on this. Thanks, Jing