From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kernel test robot <lkp@intel.com>
Cc: Hugo Villeneuve <hugo@hugovil.com>,
Jiri Slaby <jirislaby@kernel.org>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_hub6: add missing include for hub6_match_port()
Date: Wed, 15 Jul 2026 07:16:46 +0200 [thread overview]
Message-ID: <2026071505-outgrow-yelp-cd59@gregkh> (raw)
In-Reply-To: <202607150717.2YxVdWpX-lkp@intel.com>
On Wed, Jul 15, 2026 at 07:42:00AM +0800, kernel test robot wrote:
> Hi Hugo,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on c1d4ce2d9eaeccd7e8aef7ec1109df49eaf4f503]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Hugo-Villeneuve/serial-8250_hub6-add-missing-include-for-hub6_match_port/20260714-092814
> base: c1d4ce2d9eaeccd7e8aef7ec1109df49eaf4f503
> patch link: https://lore.kernel.org/r/20260714012610.576746-1-hugo%40hugovil.com
> patch subject: [PATCH] serial: 8250_hub6: add missing include for hub6_match_port()
> config: parisc-allmodconfig (https://download.01.org/0day-ci/archive/20260715/202607150717.2YxVdWpX-lkp@intel.com/config)
> compiler: hppa-linux-gcc (GCC) 16.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260715/202607150717.2YxVdWpX-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202607150717.2YxVdWpX-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> drivers/tty/serial/8250/8250_hub6.c:46:6: error: redefinition of 'hub6_match_port'
> 46 | bool hub6_match_port(const struct uart_port *port1, const struct uart_port *port2)
> | ^~~~~~~~~~~~~~~
> In file included from drivers/tty/serial/8250/8250_hub6.c:10:
> drivers/tty/serial/8250/8250.h:340:20: note: previous definition of 'hub6_match_port' with type 'bool(const struct uart_port *, const struct uart_port *)' {aka '_Bool(const struct uart_port *, const struct uart_port *)'}
> 340 | static inline bool hub6_match_port(const struct uart_port *port1, const struct uart_port *port2)
> | ^~~~~~~~~~~~~~~
>
>
> vim +/hub6_match_port +46 drivers/tty/serial/8250/8250_hub6.c
>
> ec9f47cd6a14ca drivers/serial/8250_hub6.c Russell King 2005-06-27 45
> 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21 @46 bool hub6_match_port(const struct uart_port *port1, const struct uart_port *port2)
> 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21 47 {
> 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21 48 return port1->iobase == port2->iobase && port1->hub6 == port2->hub6;
> 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21 49 }
> 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21 50 EXPORT_SYMBOL_GPL(hub6_match_port);
> 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21 51
This patch didn't cause this problem, just made it show up. Can you
provide a follow-on patch that fixes this?
thanks,
greg k-h
prev parent reply other threads:[~2026-07-15 5:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 1:26 [PATCH] serial: 8250_hub6: add missing include for hub6_match_port() Hugo Villeneuve
2026-07-14 23:42 ` kernel test robot
2026-07-15 5:16 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026071505-outgrow-yelp-cd59@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox