From: Ryan Wilbur <rwilbur633@gmail.com>
To: andriy.shevchenko@linux.intel.com
Cc: gregkh@linuxfoundation.org, hvilleneuve@dimonoff.com,
ilpo.jarvinen@linux.intel.com, jirislaby@kernel.org,
john.ogness@linutronix.de, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, manuel.lauss@gmail.com,
rwilbur633@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: clear stuck RX-timeout interrupt on LPC32xx (PORT_LPC3220)
Date: Sat, 18 Jul 2026 09:04:36 -0300 [thread overview]
Message-ID: <20260718120436.20196-1-rwilbur633@gmail.com> (raw)
In-Reply-To: <alpsOr5ZVqa_eLs9@ashevche-desk.local>
On Fri, Jul 17, 2026 at 20:54:02 +0300, Andy Shevchenko wrote:
> > + * Same bug worked around for other 8250 cores (8250_dw, 8250_omap, 8250_bcm7271).
>
> This is 8250-port.c.
>
> > + if (port->type == PORT_LPC3220 &&
>
> Why do we have this then?
dw/omap/bcm7271 handle their variants of this in their
own drivers. LPC32xx (PORT_LPC3220) has no dedicated 8250 glue driver.
I gated it on port->type because LPC32xx is the only hardware I can test
on, and I wanted to avoid changing behaviour on 8250 variants I can't
verify. That said, the read only fires on a bogus IIR=RX_TIMEOUT with LSR.DR
clear, which a healthy 16550 never reports, so it's harmless on other
parts. Unless you object, I'll drop the PORT_LPC3220 gate to allow for generic
handling.
prev parent reply other threads:[~2026-07-18 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 12:35 [PATCH] serial: 8250: clear stuck RX-timeout interrupt on LPC32xx (PORT_LPC3220) Ryan Wilbur
2026-07-17 17:54 ` Andy Shevchenko
2026-07-18 12:04 ` Ryan Wilbur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260718120436.20196-1-rwilbur633@gmail.com \
--to=rwilbur633@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox