From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B16403ACA58 for ; Sun, 19 Jul 2026 16:08:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784477316; cv=none; b=tvsa5fjMVQ8KZM9bdIRw0L/2NwtXUPchY8B+8/8d1oK8X2du4PeH75td6xEa+xra+z/PzGHo3rhVgRCIE85H1OiHZ+tHoOBJ7+6pgssWfEdsnDxqrelSjQQOu6ynBbXUIuif5eY3RpnpoCUMDPoIaiIWgzwwCb6l61zf04PxT70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784477316; c=relaxed/simple; bh=xep+DbUTODAyiI61W5CCxIKqMCWLvMAtORFdzKJXX9g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jM+AvAYIJR90LN2v3x0jvptKBDuZyxSCXQlNcqXGGOYUdwkz4kqaX8AZP6v7YJUxb0f0bxZP3mflW47oPigCcTm7HI93pytCF3H0cq9fcRb4kILuSIoT5VrqbYsMjlNeACkoCGCHLL5cLHZQC58Jdk2fZexomyuS33PyS+hM3CI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SjMADF1t; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SjMADF1t" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4955adb04e8so2938155e9.2 for ; Sun, 19 Jul 2026 09:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784477313; x=1785082113; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T7BUDbPgvu4uYiB0I4Tcu6S0zkTXWIU92UBF/zE/Z4w=; b=SjMADF1tT0usbm7wnGnkIj1TQk1PFlrmf7UpAX6ZxPtSTvo+iSsa2MevZoaGPX661i cZsBtHzdEWDUeq92jJVJwUcevx8ZHtKQzk4TG+ussm5Tp3nKo6v5y5rTQosTsm+mU207 /t0ytK70budYwCQ/m466hM3B7uGo5qExOJTROHS7Pws6qTXZJ05ZAQIsUUMo536SNoYv /MjAUTCCaLmTt3QL1Ezp40sUdQ2lFzOP08SKwJqpYx70jBWvNsrMRwAuYvXLyNo31GXG 8baPzVay1CyBznmdn/IcbW+D78dYSoIZnIU+0uI9T3zYVtiJWHT/L/72dmXkSlUa/RRy CdLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784477313; x=1785082113; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=T7BUDbPgvu4uYiB0I4Tcu6S0zkTXWIU92UBF/zE/Z4w=; b=W+vogvfmLIRAxCQxiOkN82/ukpNAOLs8uPwQ17igG+Lk0Y6pPF0c9caZCn3GH59CX+ GtfSHQjwWOtfMwJbeCVhfx7EHNUpiAwzeYbHL21HDsfXWqtzPQfpsfXgLgizhKjpKlrt 3veSdsl4Ea5J5caeyZOk96gAcaOOsVFT7M+t0e+7dMhA8flEBOYhBQ6tVgIVCqg12X/q zUVfE/j2Nb1W7ECEu50oMUJpxS6YCnIVT5UFLC9oXP6jIuX13UqCK2UtXG8Q/eL1sa4M BfdE7qUDYBx9Cj2xGW89fCRHMAI4SgbPn0GkLfxLNAjeUOuSgFL3oSB0wqcDce0CQDzh oHuQ== X-Forwarded-Encrypted: i=1; AHgh+RrQDpglUeLR42k6HKgrMARq0fkbQHqEpUwBDrG/Ac7a6y90c9xnQy0TtBikEOI+vA9Hn2tHh3zlI1eZ4aA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywo/YUECuerWrpHgxzhMv8NI6YlUCp+5UVg6WFutvJgIBomS9KA 5+m3SoBOafPLxG7pfi0pcKSk1OZB5NAigTXlgCl5NRSvZRCUkrFJyu49REdMPPSA X-Gm-Gg: AfdE7clJoF4NWWHuHTcz3pM80GiJ8PbKmUyrK+MmXXFo7i6mMEcmqHjtxS+9WiTqaFc EpULo8H1XcEPS5ANmtJjDjnq749ktPO0nnW+rNsTvZSr7uZ5rdEpkwK2cxBQf2bsRzgD0Pxv5i2 2WWc99yXxkJOrXjcRE5MMMSOXGFotaY28A8f7rG6nXe95meQ9QODxTqDKGuRev9yLvJp+b7Q8rg y8rV7ZqVVJe1B3edAORL+Ms+uJ9RTSYGyK+KcLDisDXUDibXqNecPfdJbX7V2r6NLxQrDQxP7Zg 34IBvYWwKTRcXors7sU/7MQHF5WsLsJYQkzOmeT/kvf0VwqyYfvWS0pD3uYKitK0iEM574xC1bH s7lavCRU8Oj8ZJfEUOdSwRl80hWhn8Yfc2JhCsSR3iuHd1fkj9G9W7AmP2ChjSYiCzTrxWJ6ns4 2VZHBK4aKsZx4Npegxfdr3Mv38fhvFtWX1/EfnsWSD/YDs4ZgpA1ynJ6DtrOI6dV5HcwUmLgkjV 54U04aNrrRuZOW1A2Ws8swsX9OYY0LnEYhtu6Yq2APPLliYCPeFGaFmj9Vhsf7Rj38K+hNhAj3U 2pkUli3dIg== X-Received: by 2002:a05:600d:104:b0:495:4182:4442 with SMTP id 5b1f17b1804b1-4954a50c563mr76711935e9.22.1784477312656; Sun, 19 Jul 2026 09:08:32 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-aeaf-bd01-78a0-2a2d-507f-c97c.310.pool.telefonica.de. [2a02:3100:aeaf:bd01:78a0:2a2d:507f:c97c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2edbe4sm223826745e9.12.2026.07.19.09.08.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 19 Jul 2026 09:08:31 -0700 (PDT) From: Karl Mehltretter To: Greg Kroah-Hartman , Jiri Slaby Cc: Karl Mehltretter , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 3/4] tty: don't oops in tty_unregister_device() when no cdev is registered Date: Sun, 19 Jul 2026 18:08:11 +0200 Message-Id: <20260719160812.35407-4-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260719160812.35407-1-kmehltretter@gmail.com> References: <20260719160812.35407-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit serial_core_add_one_port() keeps a uart_port when tty device registration fails so setserial can still use it. It marks the port UPF_DEAD and returns success. Removing the port later reaches tty_unregister_device(), which unconditionally passes driver->cdevs[index] to cdev_del(). The slot does not always contain a live cdev. A serdev registration error other than -ENODEV returns before tty_register_device_attr(), leaving the slot NULL. If cdev_add() fails, tty_cdev_add() drops the cdev reference but leaves the slot pointing at freed memory. The later cdev_del() is therefore a NULL dereference or use-after-free. The NULL path was reproduced with failslab during UART bind on qemu's mcimx6ul-evk and raspi1ap boards: Unhandled fault: page domain fault (0x01b) at 0x00000038 PC is at cdev_del+0x14/0x34 Clear the slot after cdev_add() fails and only call cdev_del() when it is non-NULL. This makes a non-NULL slot mean that a live cdev is registered. Fixes: c1a752ba2d6b ("tty: don't leak cdev in tty_cdev_add()") Fixes: 8cde11b2baa1 ("tty/serdev: add serdev registration interface") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter --- drivers/tty/tty_io.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 6b283fd03ff8..4889076b975f 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -3167,8 +3167,10 @@ static int tty_cdev_add(struct tty_driver *driver, dev_t dev, driver->cdevs[index]->ops = &tty_fops; driver->cdevs[index]->owner = driver->owner; err = cdev_add(driver->cdevs[index], dev, count); - if (err) + if (err) { kobject_put(&driver->cdevs[index]->kobj); + driver->cdevs[index] = NULL; + } return err; } @@ -3305,7 +3307,7 @@ EXPORT_SYMBOL_GPL(tty_register_device_attr); void tty_unregister_device(struct tty_driver *driver, unsigned index) { device_destroy(&tty_class, MKDEV(driver->major, driver->minor_start) + index); - if (!(driver->flags & TTY_DRIVER_DYNAMIC_ALLOC)) { + if (!(driver->flags & TTY_DRIVER_DYNAMIC_ALLOC) && driver->cdevs[index]) { cdev_del(driver->cdevs[index]); driver->cdevs[index] = NULL; } -- 2.53.0