From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: brgl@kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Subject: [PATCH] serial: 8250_exar: use platform_device_register_full()
Date: Tue, 28 Jul 2026 16:44:50 +0200 [thread overview]
Message-ID: <20260728-exar-pdev-reg-full-v1-1-7a96e77309e1@oss.qualcomm.com> (raw)
This driver doesn't really need to split the registration of the GPIO
chip into stages, as platform_device_info already provides fields for
the firmware node, parent device and the software node. Use
platform_device_register_full() and simplify the code. This also
addresses the problem with incorrect reference count of the assigned
firmware node.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
drivers/tty/serial/8250/8250_exar.c | 25 +++++++++----------------
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index f9a14eaa13cba85f2424c351510be093f52fd6a1..836792e861bfc742a14de90640a6252dca1bd226 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -1140,22 +1140,15 @@ static void setup_gpio(struct pci_dev *pcidev, u8 __iomem *p)
static struct platform_device *__xr17v35x_register_gpio(struct pci_dev *pcidev,
const struct software_node *node)
{
- struct platform_device *pdev;
-
- pdev = platform_device_alloc("gpio_exar", PLATFORM_DEVID_AUTO);
- if (!pdev)
- return NULL;
-
- pdev->dev.parent = &pcidev->dev;
- device_set_node(&pdev->dev, dev_fwnode(&pcidev->dev));
-
- if (device_add_software_node(&pdev->dev, node) < 0 ||
- platform_device_add(pdev) < 0) {
- platform_device_put(pdev);
- return NULL;
- }
-
- return pdev;
+ struct platform_device_info pdevinfo = {
+ .name = "gpio_exar",
+ .id = PLATFORM_DEVID_AUTO,
+ .parent = &pcidev->dev,
+ .fwnode = dev_fwnode(&pcidev->dev),
+ .swnode = node,
+ };
+
+ return platform_device_register_full(&pdevinfo);
}
static void __xr17v35x_unregister_gpio(struct platform_device *pdev)
---
base-commit: 0d33d21e47d9dc66f91e44da3fc9220c74d93df7
change-id: 20260728-exar-pdev-reg-full-e31a2447b4b3
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
reply other threads:[~2026-07-28 14:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728-exar-pdev-reg-full-v1-1-7a96e77309e1@oss.qualcomm.com \
--to=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox