Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lucas Tanure <tanure@linux.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: don't register ports that have no hardware
Date: Wed, 19 Aug 2026 08:49:09 +0200	[thread overview]
Message-ID: <2026081908-clamp-safely-de2f@gregkh> (raw)
In-Reply-To: <ecc5ada8-c878-4123-acd7-64af3219b181@linux.com>

On Wed, Aug 19, 2026 at 07:40:17AM +0100, Lucas Tanure wrote:
> On 19/08/2026 06:57, Greg Kroah-Hartman wrote:
> > On Tue, Aug 18, 2026 at 07:52:00PM +0100, Lucas Tanure wrote:
> > > The 8250 driver creates a fixed set of port slots at boot and
> > > registers a ttyS device for each one, even when the slot describes no
> > > hardware. On device tree platforms those slots are empty, but they
> > > still take the ttyS0..ttyS3 names.
> > > 
> > > New Amlogic SoCs (S4, T7) name their real UARTs ttyS as well. With
> > > both drivers built in, as in arm64 defconfig, the real port fails to bind:
> > 
> > Then fix that bug, don't break everyone else's systems because of it.
> > 
> Hi,
> 
> Understood. I thought preventing 8250 from probing on devices that don't use
> it would be a good idea, and fix my bug. Thanks for the feedback.
> 
> I will tak to Amlogic list the ttyS name collision introduced for the new
> Amlogic SoCs in e71aab9d6132.

That was an explicit decision by Amlogic to do that, so there should not
be any collisions as their systems should NOT be having the older 8250
device tree entries.

So perhaps just fix your device tree to not be broken?

thanks,

greg k-h

  reply	other threads:[~2026-08-19  6:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 18:52 [PATCH] serial: 8250: don't register ports that have no hardware Lucas Tanure
2026-08-19  4:42 ` Jiri Slaby
2026-08-19  6:31   ` Lucas Tanure
2026-08-19  5:57 ` Greg Kroah-Hartman
2026-08-19  6:40   ` Lucas Tanure
2026-08-19  6:49     ` Greg Kroah-Hartman [this message]
2026-08-19  7:31       ` Lucas Tanure
2026-08-19  7:46         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026081908-clamp-safely-de2f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=tanure@linux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox