From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Kendall Willis <k-willis@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Peter Hurley <peter@hurleysoftware.com>,
Tony Lindgren <tony@atomide.com>,
s-kochidanadu@ti.com, a-kaur@ti.com, s-tripathi1@ti.com,
vishalm@ti.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_omap: fix wake irq cleared during suspend
Date: Tue, 25 Aug 2026 09:27:12 +0200 [thread overview]
Message-ID: <20260825072712.jR_IlVlw@linutronix.de> (raw)
In-Reply-To: <20260824-uart-wakeirq-fix-v1-1-6d81a230a1c4@ti.com>
On 2026-08-24 11:28:51 [-0500], Kendall Willis wrote:
> The wake irq was cleared in shutdown(), which runs during the suspend
> sequence, making it impossible to wake the system via UART.
> Move wake irq setup to probe() and teardown to remove() so the irq
> remains armed during suspend when the UART is a wakeup source.
>
> Cc: stable@vger.kernel.org
> Fixes: 61929cf0169d ("tty: serial: Add 8250-core based omap driver")
> Signed-off-by: Kendall Willis <k-willis@ti.com>
I leave this to Tony. I tested it back then on bbb and wake up from idle
was a requirement which worked. Tony had other boards which passed the
test, too.
The omap driver had and has the same logic here.
Sebastian
next prev parent reply other threads:[~2026-08-25 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 16:28 [PATCH] serial: 8250_omap: fix wake irq cleared during suspend Kendall Willis
2026-08-24 16:41 ` sashiko-bot
2026-08-25 7:27 ` Sebastian Andrzej Siewior [this message]
2026-08-25 14:52 ` Kendall Willis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260825072712.jR_IlVlw@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=a-kaur@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=k-willis@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=s-kochidanadu@ti.com \
--cc=s-tripathi1@ti.com \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox