Linux Serial subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sasha Levin" <sashal@kernel.org>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.18] serial: 8250_port: recognize UPIO_AU
Date: Mon, 31 Aug 2026 14:19:49 +0000	[thread overview]
Message-ID: <20260831141950.12FE81F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260831133314.4125787-85-sashal@kernel.org>

> From: Manuel Lauss <manuel.lauss@gmail.com>
> 
> [ Upstream commit 49fa670efdfdd27e29145cbd2beef065c08717ef ]
> 
> My MIPS Alchemy systems generate the following warning during
> probe of the 8250 driver:
> 
> WARNING: drivers/tty/serial/8250/8250_port.c:462 at set_io_from_upio+0xfc/0x124, CPU#0: swapper/0/1
> Unsupported UART type 4
> [...]
> [<80521d40>] set_io_from_upio+0xfc/0x124
> [<80521dfc>] serial8250_set_defaults+0x94/0xe0
> [<80520fb4>] serial8250_register_8250_port+0x288/0x51c
> [<805214ec>] serial8250_probe+0x160/0x1e8
> [<8053b5f0>] platform_probe+0x64/0x90
> 
> The least invasive fix is to recognize UPIO_AU (type 4) in set_io_from_upio()
> and do nothing, since all parameters have already been set up in
> 8250_rt288x.c::au_platform_setup().
> 
> Run-tested on Alchemy Au1300 platform.
> 
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> Link: https://patch.msgid.link/20260430135822.905035-1-manuel.lauss@gmail.com
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831133314.4125787-85-sashal@kernel.org?part=1


      reply	other threads:[~2026-08-31 14:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260831133314.4125787-1-sashal@kernel.org>
2026-08-31 13:21 ` [PATCH AUTOSEL 6.18-5.10] serial: 8250: fix possible ISR soft lockup Sasha Levin
2026-08-31 13:58   ` sashiko-bot
2026-08-31 13:21 ` [PATCH AUTOSEL 6.18] tty: serial: 8250: protect against NULL uart->port.dev in register Sasha Levin
2026-08-31 14:21   ` sashiko-bot
2026-08-31 13:21 ` [PATCH AUTOSEL 6.18] serial: 8250_port: recognize UPIO_AU Sasha Levin
2026-08-31 14:19   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260831141950.12FE81F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashal@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox