From: Adriano Cordova <adrianox@gmail.com>
To: gregkh@linuxfoundation.org
Cc: johan@kernel.org, jirislaby@kernel.org,
linux-usb@vger.kernel.org, linux-serial@vger.kernel.org,
Adriano Cordova <adrianox@gmail.com>,
syzbot+473d7477c523b41d4046@syzkaller.appspotmail.com
Subject: [PATCH v2 0/2] tty: fix break race
Date: Thu, 3 Sep 2026 00:24:27 -0400 [thread overview]
Message-ID: <20260903042429.130320-1-adrianox@gmail.com> (raw)
A timed break (TCSBRK/TCSBRKP) and the unconditional TIOCSBRK/TIOCCBRK
can race against USB disconnect and call break_ctl() after the device is
gone, dereferencing freed port data in keyspan_break_ctl().
Both patches are needed: the tty core must not issue break_ctl() to a
hung-up tty, and serial_break() must not call the driver after
disconnect. This is the same two-layer protection read and write already
use.
Changes since v1:
- v1 https://lore.kernel.org/stable/20260903022452.111316-2-adrianox@gmail.com/T/#t
- Proper check on the tty side, plus check on the USB side.
- Tested syzbot
Reported-by: syzbot+473d7477c523b41d4046@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=473d7477c523b41d4046
Tested-by: syzbot+473d7477c523b41d4046@syzkaller.appspotmail.com
Adriano Cordova (2):
USB: serial: fix break_ctl() NULL-pointer dereference
tty: fix break race
drivers/tty/tty_io.c | 19 +++++++++++++++----
drivers/usb/serial/usb-serial.c | 3 +++
2 files changed, 18 insertions(+), 4 deletions(-)
--
2.51.0
next reply other threads:[~2026-09-03 4:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 4:24 Adriano Cordova [this message]
2026-09-03 4:24 ` [PATCH v2 1/2] USB: serial: fix break_ctl() NULL-pointer dereference Adriano Cordova
2026-09-03 4:41 ` sashiko-bot
2026-09-03 4:24 ` [PATCH v2 2/2] tty: fix break race Adriano Cordova
2026-09-03 4:40 ` sashiko-bot
2026-09-03 6:22 ` [PATCH v2 0/2] " Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903042429.130320-1-adrianox@gmail.com \
--to=adrianox@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=syzbot+473d7477c523b41d4046@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox