From: sashiko-bot@kernel.org
To: "Myeonghun Pak" <mhun512@gmail.com>
Cc: linux-serial@vger.kernel.org, wsa+renesas@sang-engineering.com
Subject: Re: [PATCH] serial: sh-sci: Unregister UART on sysfs setup failure
Date: Fri, 11 Sep 2026 03:20:57 +0000 [thread overview]
Message-ID: <20260911032057.C054D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911031500.5745-1-mhun512@gmail.com>
> sci_probe_single() registers the UART port before sci_probe() creates
> the RX FIFO tuning attributes. If either device_create_file() call
> fails, probe returns an error without removing the port from the serial
> core. Device-managed resources are then released while the port remains
> registered.
>
> Unregister the UART port before returning either sysfs creation error.
> If the second attribute fails, remove the first attribute before
> unregistering the port. Keep the existing probe failure policy and leave
> the successful initialization path unchanged.
>
> This issue was identified during our ongoing static-analysis research while
> reviewing kernel code.
>
> Fixes: 5d23188a473d ("serial: sh-sci: make RX FIFO parameters tunable via sysfs")
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260911031500.5745-1-mhun512@gmail.com?part=1
prev parent reply other threads:[~2026-09-11 3:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 3:15 [PATCH] serial: sh-sci: Unregister UART on sysfs setup failure Myeonghun Pak
2026-09-11 3:20 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911032057.C054D1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mhun512@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox