Re: [PATCH] vt: keyboard: Allocate new_map with ARRAY_SIZE()

[sashiko-bot@kernel.org]

> From: Kees Cook <kees+treewide@kernel.org>
> 
> In preparation for converting the kmalloc family of allocators to the
> type-aware kmalloc_obj family, we need to make sure that the returned
> type from the allocation matches the type of the variable being
> assigned. (The kmalloc family returns "void *", which can be implicitly
> cast to any pointer type.)
> 
> The new key map has as many entries as plain_map, but the size was taken
> from the whole array, which would make the allocation type a pointer to
> the array rather than the "unsigned short *" being assigned. Allocate
> ARRAY_SIZE-many entries instead. The resulting allocation size is the
> same.
> 
> Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0:
> drivers/tty/vt/keyboard.o
> 
> Assisted-by: LLM coccinelle
> Signed-off-by: Kees Cook <kees+treewide@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917211539.i.636-kees@kernel.org?part=1