Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: sashiko-reviews@lists.linux.dev
Cc: Markus Probst <markus.probst@posteo.de>,
	gary@garyguo.net, linux-serial@vger.kernel.org, ojeda@kernel.org
Subject: Re: [PATCH v2 1/3] tty: serdev: Export functions to pause receive_buf callback calls
Date: Wed, 23 Sep 2026 12:36:10 +0200	[thread overview]
Message-ID: <2026092347-blend-enrich-b4fa@gregkh> (raw)
In-Reply-To: <20260920144023.B874E1F000FF@smtp.kernel.org>

On Sun, Sep 20, 2026 at 02:40:23PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] tty: missing hardware memory barrier after test_bit() on weakly ordered archs

Ah, look, I was right :)

This is all really really fragile, please reconsider it all.

thanks,

greg k-h

  reply	other threads:[~2026-09-23 10:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-20 14:29 [PATCH v2 0/3] rust: serdev: Refactor Markus Probst
2026-09-20 14:29 ` [PATCH v2 1/3] tty: serdev: Export functions to pause receive_buf callback calls Markus Probst
2026-09-20 14:40   ` sashiko-bot
2026-09-23 10:36     ` Greg KH [this message]
2026-09-23 10:35   ` Greg Kroah-Hartman
2026-09-23 13:31     ` Markus Probst
2026-09-23 13:52       ` Gary Guo
2026-09-23 15:06         ` Markus Probst
2026-09-23 14:26       ` Greg Kroah-Hartman
2026-09-23 15:03         ` Markus Probst
2026-09-20 14:30 ` [PATCH v2 2/3] rust: serdev: Replace `active` mutex with receive pause Markus Probst
2026-09-20 14:39   ` sashiko-bot
2026-09-20 14:30 ` [PATCH v2 3/3] rust: serdev: Simplify callbacks Markus Probst
2026-09-20 14:44   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026092347-blend-enrich-b4fa@gregkh \
    --to=greg@kroah.com \
    --cc=gary@garyguo.net \
    --cc=linux-serial@vger.kernel.org \
    --cc=markus.probst@posteo.de \
    --cc=ojeda@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox