Linux Serial subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: cpm_uart: use irq variable for platform_get_irq()
Date: Fri, 25 Sep 2026 18:22:01 +0000	[thread overview]
Message-ID: <20260925182201.B3B2B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260925181530.52953-1-rosenp@gmail.com>

> struct uart_port has its irq member as an unsigned int, which does not
> work when platform_get_irq() returns an error.
> 
> Use a local irq variable to handle this and write to struct uart_port's
> irq member when platform_get_irq() succeeds. On success, it returns an
> IRQ >= 0, which is representable by unsigned int.
> 
> Fixes: 831603b3e8aa ("serial: cpm_uart: replace irq_of_parse_and_map with platform_get_irq")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202609251916.1XlVHLwd-lkp@intel.com/
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925181530.52953-1-rosenp@gmail.com?part=1


  reply	other threads:[~2026-09-25 18:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-25 18:15 [PATCH] serial: cpm_uart: use irq variable for platform_get_irq() Rosen Penev
2026-09-25 18:22 ` sashiko-bot [this message]
2026-10-01  8:46 ` Greg Kroah-Hartman
2026-10-01 20:38   ` Rosen Penev
2026-10-02  5:54     ` Greg Kroah-Hartman
2026-10-03 21:32       ` Rosen Penev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925182201.B3B2B1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=rosenp@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox