Re: [PATCH v3 2/5] rust: mem: add DropGuard

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: vertical import style violation for core::ops
--

commit 14b3938196a8942ce3b9aa406f0d5ba59f964b6e
Author: Mohamed Osama <mohamed.osama189110@gmail.com>

rust: mem: add DropGuard

This commit adds DropGuard to the Rust kernel memory module to run a cleanup
callback when dropped, mirroring the upstream core::mem::DropGuard API. It
keeps ScopeGuard for existing users but establishes the new kernel API
alongside it.

> diff --git a/rust/kernel/mem.rs b/rust/kernel/mem.rs
> index f2d4cdf87d00b..e7a84d15f3b38 100644
> --- a/rust/kernel/mem.rs
> +++ b/rust/kernel/mem.rs
> @@ -4,6 +4,93 @@
>  
>  use crate::prelude::*;
>  
> +use core::mem::ManuallyDrop;
> +use core::ops::{Deref, DerefMut};

[Severity: Low]
This isn't a bug, but this import statement groups multiple items together,
failing to adhere to the kernel's vertical import style guidelines. Should
Deref and DerefMut be imported on separate lines?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926173315.56772-1-mohamed.osama189110@gmail.com?part=2