From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: imx@lists.linux.dev, linux-serial@vger.kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v2 2/2] serial: amba-pl011: use dmaengine public API instead of raw ops
Date: Mon, 28 Sep 2026 18:39:55 +0000 [thread overview]
Message-ID: <20260928183955.DA3601F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260928183252.1965169-2-Frank.Li@oss.nxp.com>
> From: Frank Li <Frank.Li@nxp.com>
>
> Replace direct calls to the internal DMA device ops
> (device->device_tx_status() and device->device_issue_pending())
> with the proper public DMA engine wrappers:
> - dmaengine_tx_status()
> - dma_async_issue_pending()
>
> Drivers must not call device ops directly; the wrappers provide
> locking, debug checks, and a stable interface that hides internal
> implementation details of the DMA controller driver.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260928183252.1965169-1-Frank.Li@oss.nxp.com?part=2
next prev parent reply other threads:[~2026-09-28 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 18:32 [PATCH v2 1/2] serial: use dmaengine_get_dma_device() instead of chan->device->dev Frank.Li
2026-09-28 18:32 ` [PATCH v2 2/2] serial: amba-pl011: use dmaengine public API instead of raw ops Frank.Li
2026-09-28 18:39 ` sashiko-bot [this message]
2026-09-28 18:41 ` [PATCH v2 1/2] serial: use dmaengine_get_dma_device() instead of chan->device->dev sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928183955.DA3601F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox