From: Greg KH <gregkh@linuxfoundation.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: "Jan Čermák" <sairon@sairon.cz>,
florian.fainelli@broadcom.com, rjui@broadcom.com,
sbranden@broadcom.com, phil@raspberrypi.com, stefan@agner.ch,
bcm-kernel-feedback-list@broadcom.com,
linux-serial@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] serial: 8250_bcm2835aux: Add support for RTS/CTS auto flow control
Date: Thu, 1 Oct 2026 10:39:38 +0200 [thread overview]
Message-ID: <2026100123-dipper-amnesty-f721@gregkh> (raw)
In-Reply-To: <2e420fc4-e829-42ea-99c2-48e518ac59d9@kernel.org>
On Thu, Oct 01, 2026 at 08:09:32AM +0200, Jiri Slaby wrote:
> On 30. 09. 26, 14:56, Jan Čermák wrote:
> > --- a/drivers/tty/serial/8250/8250_bcm2835aux.c
> > +++ b/drivers/tty/serial/8250/8250_bcm2835aux.c
> ...
> > @@ -46,6 +59,150 @@ struct bcm2835aux_data {
> > u32 cntl;
> > };
> > +static bool bcm2835aux_tty_throttled(struct uart_port *port)
> > +{
> > + struct tty_struct *tty;
> > + bool throttled;
> > +
> > + if (!port->state)
> > + return false;
> > +
> > + tty = tty_port_tty_get(&port->state->port);
> > + throttled = tty && tty_throttled(tty);
> > + tty_kref_put(tty);
> > +
> > + return throttled;
>
> Instead:
>
> scoped_guard(tty_port_tty, port)
> return tty_throttled(scoped_tty());
>
> return false;
LLMs do not understand "modern" kernel programming styles :(
prev parent reply other threads:[~2026-10-01 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 12:56 [PATCH v2] serial: 8250_bcm2835aux: Add support for RTS/CTS auto flow control Jan Čermák
2026-09-30 13:11 ` sashiko-bot
2026-10-01 6:09 ` Jiri Slaby
2026-10-01 8:39 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026100123-dipper-amnesty-f721@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=sairon@sairon.cz \
--cc=sbranden@broadcom.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox