Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: jirislaby@kernel.org, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: n_tty: convert the full VTIME interval to jiffies
Date: Thu, 29 Oct 2026 07:23:29 +0100	[thread overview]
Message-ID: <2026102957-suitable-gesture-be83@gregkh> (raw)
In-Reply-To: <20261029002052.54117-1-dennylin0707@gmail.com>

On Thu, Oct 29, 2026 at 12:20:52AM +0000, Hungyu Lin wrote:
> VTIME specifies a timeout in tenths of a second, but n_tty_read() divides
> HZ by 10 before multiplying by VTIME. For supported HZ values that are
> not divisible by 10, this truncates each decisecond and shortens the
> requested interval. For example, HZ=128 and VTIME=40 produce 480 ticks
> instead of 512 ticks for four seconds.

What real system uses HZ=128 ?

In other words, is this a real issue at all?

thanks,

greg k-h

  parent reply	other threads:[~2026-10-29  6:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29  0:20 [PATCH] tty: n_tty: convert the full VTIME interval to jiffies Hungyu Lin
2026-10-29  0:24 ` sashiko-bot
2026-10-29  6:23 ` Greg KH [this message]
2026-10-29  6:38   ` Hungyu Lin
2026-10-29  7:04     ` Greg KH
2026-10-29  7:52       ` Hungyu Lin
2026-10-29  8:09         ` Greg KH
2026-10-29  8:17           ` Hungyu Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026102957-suitable-gesture-be83@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dennylin0707@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox