From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.49 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793399838; b=oK73I1lclOnqhxBFSNdXXL01g/BzwR8zd1m/VwWRZnrh5mr7/N9ceY9xBXqlMCaMb7N/ r56FP17g556R7JVsj6dqvS6rmujyembum0SNqdSUgOQv3yRBbQi2d5Zd6/6YhoS95AyHo MWT43HoSKe4EcDOC1Avx9kWyjGlTsnVb7E1fQ7o0u+4tpUIrDHXdGA/4NOVHLjJPV47Ns AzBSp142SapxHxmX5PL+UVc1aSQ2as5c60ss/lmooJfENXLK11vgdhoLDgVHLdMyqxiXR d3wejmgeQTA1vxP5VGLjtzk+HySPMWug3+f/xqNE/UlV6B+wY++DHhPoP73uAe7IlGg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793399838; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=pNehLARC7qvOa4dOkHR5b0YmY6kYtso4GzuHZMjqnQY=; b=kdgtooC2ayQvdAGxt0ojEfmeigU6RJssooqVkKPUqONOHX3WtO14ghiBuF6RJhJ/wa6z QJb9/4aShPOVRDPFnXxbOfgmzcFVKEHFMdEItvPEWUyB7XEZX3UMOgumEURgergZV6b/9 qkgAUMFx3imeiAZ+QaKVSM278iQQQZOh2utcc+rVg5nJPDEfvBxS+gwNCoZy9Kr2nGZki dtNlx23mq3VUp7cZfJuyb5CLQy5CbYWX+nZPuFh6ZOkLN9dDwD1E4mZpknggBzZ10IXvc Bt6wxGQWwciVc6UkFJ51OdQBbJjjCHh1KdORySoQlGwluFtv8FdTDBQzUTt4UxvtHHw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Lj8XtCWp; arc=none smtp.remote-ip=209.85.221.49 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BCA060A2634 for ; Fri, 30 Oct 2026 22:37:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3BCA060A2634 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Lj8XtCWp Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-48dee593f18so993547f8f.3 for ; Fri, 30 Oct 2026 15:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793399837; x=1794004637; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pNehLARC7qvOa4dOkHR5b0YmY6kYtso4GzuHZMjqnQY=; b=Lj8XtCWpgrhdkkc1l0JBl7kexeOB2LGOh6ikC1MoEHtPGNa+QPgwcnBzjEluqZPFFs FdMV0s81vmkKar/h4lhnyGuNDfIdzW5XLbl8TjMtQ2rhTp/n8SNfDhbA6GOBxXr7fuhv QnNszvB0Xzl6eoQXd+uT7fzvkYnSC95SAxDLzIzfsVkYzvzCnOj6ffL7KgyVwYbCk8tn sITMf2BA+k+TKjy538d5NZSqj4PqD8kmAFIlc2zEqOIMzPfYS39PN7Asv/UCQIRfgseG E6gME8Cl+dXKqn2+ugabSg7oi1yRj2+E4IeZyH+1F0WeAdhXArd/KGorhYr2XZEfAJTA qbYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793399837; x=1794004637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=pNehLARC7qvOa4dOkHR5b0YmY6kYtso4GzuHZMjqnQY=; b=uN5L5rs8XIuKLTp8uL470rY6vvUI9tdn49TtjW/cN4Vjn4TlfRyJnbw9S0SshuHGw1 0eT/o/8soF9lOmUX4zaaJKPp6ft1B5TLcHUh3RyKdAIMIVzvL7qTlWcOO3RdrnQX8/U9 Uzbj9agcUe9wVCJCgJdugB8wn85GbhHDExS52Puhq409L0YgBe5v18szx3v893JvG+bU oGDlK7ru+JLLVhFLQ3xmzAy4g/7xXzWqFZr/fN5or0zo6cezFLQzqM0Vtdyv3rgjrPNm WOaPPnqbuxaZBP6xEQYD0mwyprGwM8qARg1T9DfIRMW/aPvmPVsI0tQKVoywTgDwf4u9 zmPQ== X-Forwarded-Encrypted: i=1; AKwUvBxvBRXLbZJOCSgQbSPWL24aXQueNtFkhusSd+QIMYKU+WEInTLSlEMBdJDtgoR2EO+fEoqk7JmfsMKhVUY=@vger.kernel.org X-Gm-Message-State: AFq9FYLb9fHWqJ9kraJ9Xc85GQsRl5+9ncW5lESb2v/QyAhCsuqrVio5 aQmQ540eClBJy7O/9NXz1mTxYqCk5OLLpb+wH6pH4JdV4V6qf69g2D5s X-Gm-Gg: AYBFou2zrOi/5cFFJDN+wg9uNsHcICjw1x1OU7jFkfyot98uaxmj+WvZY1uPOgFSEvy iDtWEYfjwi9Yf+smN10+PB1/6V5lbCLHXpfPxPCwr4+Y6Toijt3ByIwLWrPE1lUBj2Cq3GDTf3j 4f8Qg1wK3vPep+/vAyBKnmJ7bfjM2I9MTm01RoTI11Thok3StTZiD8PsS1oDkFrc++/HlaBmk25 2Md1CIXgucZX7FuvdC6HJD38q0xfspHVq3BRFxaRFPQhjOwRFY2pZzBWdxyHjpcMOe7ovdqOG2/ gE+ngSDy/x51B8rnOPzPP3M7HiIl/0IVCkeWaZY/KdDnIX4cl/2mpNQETC+UBPzATUb4MkFeoJm UQta0y3nJJgbULAK1o5ScEGhoytZDkYyYJFTwdsrDmYqklt6fVfi2j9CIC90OLLwtRSLTSxdq48 6zZTdrTnE/msr5sW6S3oUWn0tC4/2wH9TmEB3sUzeWcU/x64MT0TXkLW8mza9Q32adZGKRmJ8DL hFDgeih1hOOa3H05Uo5l7p82jV5b2MIRugx6tudy/WFrlO7kHdJ/TJdo1qyfvw4OBdUxsguTivQ jGwLYynHZhZNeaC3u+SMKB1lbWfdioGgfiPjFPhPO9Awa0CbwQ== X-Received: by 2002:a05:6000:4021:b0:48e:4300:c70e with SMTP id ffacd0b85a97d-48e6e304059mr8145616f8f.46.1793399836599; Fri, 30 Oct 2026 15:37:16 -0700 (PDT) Received: from m2.. ([37.142.145.227]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-48e71b959c1sm5457300f8f.45.2026.10.30.15.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2026 15:37:16 -0700 (PDT) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH v2 09/15] HID: ft260: group sysfs attrs per HID interface Date: Sat, 31 Oct 2026 00:36:31 +0200 Message-ID: <20261030223637.86907-10-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261030223637.86907-1-michael.zaidman@gmail.com> References: <20261030223637.86907-1-michael.zaidman@gmail.com> X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Split the single sysfs attribute group into per-interface groups based on chip mode (DCNF0/DCNF1): - I2C-only (mode 1): I2C and GPIO attributes on the I2C HID interface - Dual mode (0/3): hid_over_i2c_en, i2c_reset and clock on the I2C interface; GPIO and UART attrs on the UART interface - UART-only (mode 2): GPIO and UART attrs on the UART interface Put i2c_enable on the UART group. In modes 0 and 3 ft260_gpio_init() runs from the UART probe, so that interface registers the gpiochip. A write to i2c_enable updates dev->gpio_en of the interface that owns the attribute. On the I2C interface the write would re-mux GPIO0 and GPIO1 on the chip and leave the gpiochip's mask unchanged, so the two lines would stay unavailable. Do not expose i2c_reset on the UART group (reported by Sashiko). Signed-off-by: Michael Zaidman --- v2: i2c_enable moves to the UART group, which owns the gpiochip; UART group drops i2c_reset (reported by Sashiko). --- drivers/hid/hid-ft260.c | 60 ++++++++++++++++++++++++++++++++++------- 1 file changed, 51 insertions(+), 9 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index 4106066b6a89..dca0250f2c25 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -1630,7 +1630,7 @@ static ssize_t i2c_reset_store(struct device *kdev, } static DEVICE_ATTR_WO(i2c_reset); -static const struct attribute_group ft260_attr_group = { +static const struct attribute_group ft260_i2c_chip_mode_1_attr_group = { .attrs = (struct attribute *[]) { &dev_attr_chip_mode.attr, &dev_attr_pwren_status.attr, @@ -1641,8 +1641,6 @@ static const struct attribute_group ft260_attr_group = { &dev_attr_gpio2_func.attr, &dev_attr_gpioa_func.attr, &dev_attr_gpiog_func.attr, - &dev_attr_uart_mode.attr, - &dev_attr_uart_dcd_ri.attr, &dev_attr_clock_ctl.attr, &dev_attr_i2c_reset.attr, &dev_attr_clock.attr, @@ -1650,6 +1648,32 @@ static const struct attribute_group ft260_attr_group = { } }; +static const struct attribute_group ft260_i2c_chip_mode_0_3_attr_group = { + .attrs = (struct attribute *[]) { + &dev_attr_hid_over_i2c_en.attr, + &dev_attr_i2c_reset.attr, + &dev_attr_clock.attr, + NULL + } +}; + +static const struct attribute_group ft260_uart_chip_mode_0_2_3_attr_group = { + .attrs = (struct attribute *[]) { + &dev_attr_chip_mode.attr, + &dev_attr_pwren_status.attr, + &dev_attr_suspend_status.attr, + &dev_attr_power_saving_en.attr, + &dev_attr_i2c_enable.attr, + &dev_attr_gpio2_func.attr, + &dev_attr_gpioa_func.attr, + &dev_attr_gpiog_func.attr, + &dev_attr_uart_mode.attr, + &dev_attr_uart_dcd_ri.attr, + &dev_attr_clock_ctl.attr, + NULL + } +}; + static DEFINE_MUTEX(ft260_uart_list_lock); static LIST_HEAD(ft260_uart_device_list); @@ -2275,7 +2299,16 @@ static int ft260_i2c_probe(struct ft260_device *dev, if (ret) goto err_i2c_free; - ret = sysfs_create_group(&hdev->dev.kobj, &ft260_attr_group); + ret = sysfs_create_group(&hdev->dev.kobj, + &ft260_i2c_chip_mode_1_attr_group); + if (ret < 0) { + hid_err(hdev, "failed to create sysfs attrs\n"); + goto err_i2c_free; + } + } else if (cfg->chip_mode == FT260_MODE_ALL || + cfg->chip_mode == FT260_MODE_BOTH) { + ret = sysfs_create_group(&hdev->dev.kobj, + &ft260_i2c_chip_mode_0_3_attr_group); if (ret < 0) { hid_err(hdev, "failed to create sysfs attrs\n"); goto err_i2c_free; @@ -2341,12 +2374,14 @@ static int ft260_uart_probe(struct ft260_device *dev, cfg->uart_mode = FT260_UART_CFG_FLOW_CTRL_NONE; if (dev->chip_mode & FT260_MODE_UART || - dev->chip_mode == FT260_MODE_ALL) { + dev->chip_mode == FT260_MODE_ALL || + dev->chip_mode == FT260_MODE_BOTH) { ret = ft260_gpio_init(dev, cfg); if (ret) goto err_hid_report; - ret = sysfs_create_group(&hdev->dev.kobj, &ft260_attr_group); + ret = sysfs_create_group(&hdev->dev.kobj, + &ft260_uart_chip_mode_0_2_3_attr_group); if (ret < 0) { hid_err(hdev, "failed to create sysfs attrs\n"); goto err_hid_report; @@ -2464,11 +2499,18 @@ static void ft260_remove(struct hid_device *hdev) dev->index); ft260_uart_port_remove(dev); if (dev->chip_mode & FT260_MODE_UART || - dev->chip_mode == FT260_MODE_ALL) - sysfs_remove_group(&hdev->dev.kobj, &ft260_attr_group); + dev->chip_mode == FT260_MODE_ALL || + dev->chip_mode == FT260_MODE_BOTH) + sysfs_remove_group(&hdev->dev.kobj, + &ft260_uart_chip_mode_0_2_3_attr_group); } else { if (dev->chip_mode == FT260_MODE_I2C) - sysfs_remove_group(&hdev->dev.kobj, &ft260_attr_group); + sysfs_remove_group(&hdev->dev.kobj, + &ft260_i2c_chip_mode_1_attr_group); + else if (dev->chip_mode == FT260_MODE_ALL || + dev->chip_mode == FT260_MODE_BOTH) + sysfs_remove_group(&hdev->dev.kobj, + &ft260_i2c_chip_mode_0_3_attr_group); i2c_del_adapter(&dev->adap); } -- 2.43.0