From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.51 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793399829; b=4s7uwDqQmi9xiID2GKFIQccf7Y+OMaHGcHgxXmOefkh7GTjy0495Dom6S6mkMnWydfa5 vR3TsTqXyJYesfwXko86/QEivlZbKHCMNPEq1sVnM4H/GtCiW2hFfYpq6wTHHrq1odv4j H9hXsFfeBJHUMjWGvjKscKsWh/K2DyflPEEWmeeXzna4DVCmVW1Yxv9wbc0j31NT2h2E9 LBHztUSjquu8xuvQNIYbh2AEocQoEK0JBWbVDV90C74XqM3bkBZ850H34a3pvJAgeS8YU 9KP/K9YUXomicCGps3QmqY5iMF522IQp+WrDyS4/BYWIPaKzWVIbhj7NnTEnogMkttw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793399829; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=JTE/z18z9ZA/r3X5bUnDyeVPzt0i08fqynrLX8skefw=; b=q4EiODVVHOB3aDtE1knPEY6JS8KcTz7JEOSnhtSqHh8YEg00Q+r2zHh9sfwz8bEXUUEC I5VnOatVnUeFuI3h6jI1BnHUgUqD04cO/uvQplhLOZ42i/AH8Hl59cTSKa27J+gbD/G3W JS40o3hXFX9NpjfT90GFJh+Dw55u3VpVFkemMdeMVhDAOe8RAoPTh+7bmWc/0iOS8p59r 39HCWk4quC0OEbV/pjQ0Co0r64KTGj+OOJT5JGMHhefbxJj/ULD/u/mu2Lg9cGLoPWyU7 rzTj9mONiZrm0AzOYmAPcY68z4kHeJ5iO4fkmLHgSDw+0fCc4plhwFUniOX5ipQIjpA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=t3w6AXSB; arc=none smtp.remote-ip=209.85.221.51 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E42E606A337 for ; Fri, 30 Oct 2026 22:37:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4E42E606A337 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=t3w6AXSB Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-48af4d4e61fso700989f8f.2 for ; Fri, 30 Oct 2026 15:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793399827; x=1794004627; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JTE/z18z9ZA/r3X5bUnDyeVPzt0i08fqynrLX8skefw=; b=t3w6AXSByaT6gcCicsKZNzDXGesNxngeLdT2vwwdzCcCs1IR7xtfpKb+GpOJq9U5wX 2JLGFeE4OwjdVSbsSn3mbifgPb9u7qbZELJMKiwpxU3IBl0Z2nM6A0DU/LHUP95h4HJK QmGtmN1xuDh4QNHFWnGItjr7LsLrrSqwP0lGdJS8WCngYbAMMBaLDWXOweAyFrg0aqro HSPj56YRd4WL/oeZZlMChJM6vYlLe8I2xj/6TWuiIRwtgEu+RdoV1eF5jXFlp7vbNpH/ +QOEztPSmZp7tGfgw7PczW8kCvE+I/V4oBKbxqO38fgaLfUsjgtfLbqsxVViVIRZBAQm dVTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793399827; x=1794004627; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JTE/z18z9ZA/r3X5bUnDyeVPzt0i08fqynrLX8skefw=; b=0WC2NLilc8ZYzJB751Miet+wbtR/R8QH3JezQpP1XYmbGP8mnAgSZyzMBa5Pydc38K xJCOpnDwR1lyH64kLliaQMfUlj+O7fHE071MjrXYwhH6QSDaKH0O0TVZ1KT3mN4RGvWj 3+W9HUiIMv05YLfVGMvo5s7oiaaFvG80DvLwG42Trmko+ZS3ir1FQg2BsjDTcTAjkvx1 vnUZxnQx/IeRvxsCklONGDnCMGvrL+7H6Qy3TWoXNOKC8IrXPedcx4lyngK3DvLA4Oa4 g6RZrcMacpDUTrLQXxH6VgqIIKjGV3yyer9Q1SspaRPHmRcF0zfHq7i+isyfGoRbGQpp AavQ== X-Forwarded-Encrypted: i=1; AKwUvBynezPdKi2ez9Sn3AKJHSpLoDefTBeXQRerNcbFKDG1HUUelQbQssTjK+uTaQsIWcvpHFpOBXRHTiohHkg=@vger.kernel.org X-Gm-Message-State: AFq9FYIf+6E22qax3Q7SBUWHqojbsR6219N+BKu+JDr0uXcNi9vkAGxn +XYddgyKWSiDT62FHwiEdkKBRWwKHIuks/PsboD63VzWk3CcrrKVB5cK X-Gm-Gg: AYBFou0ovimb8IYGT4Jrh1GVx6lRfWfyCcbBxiVkL3f6ZkRJwwI6V+uTNX/ewvYJ5bu rhRNNhEDNY/l8qD8vCoGAesHwZf6bFwD//l4fykDxpybbj98la77i2RfRHygLxGhcu2SoRMTuOg u3+vsJaHKyiSxKGaiu4RMmctQto36VIbPc0z4Gedpkz9NKyTdX8lGDMlYOzKnIwCOGASDCS0ERQ Upkuu0CMN9ot2N1UUWVcLvaJoDZB/GHrSsNoPFpfWtc0LyjFtyN2TBdy61lZixZitVUUu+ea40+ geawtPSEmPqan3Ugsc3WSHPuz89Pd+/iCk21Kk+sNQIuHM5zeuMyP2hf6rQ3/+53sVrtk98xecv ky9Z0hNyz0x1dbTo3crBWsqVE6y/yxVnKFPcRpA1WPBxw4bCl6teKgA6uywquprta2QGnSRlwRW 8DibCAq7371sgd7sHW/w2z0Ve/t+PG6Ued20ffYuNfF2a2MZ0HegzPCyS7c1q4eKKlF4+MxERv7 JHkxCehCTvAeWjPCjjj3KPDh1tPhWVv6M73lJkeWeKa98/udDIBk66sSicPc51C1rpjW7Pf8i19 lTGk4Sh+9LKr3j8aAvRRFnL/o1cuyeoFkR/OjMiyqNPrWH06tQ== X-Received: by 2002:a05:6000:2886:b0:48b:1119:5756 with SMTP id ffacd0b85a97d-48e6e2f6739mr8445762f8f.17.1793399826540; Fri, 30 Oct 2026 15:37:06 -0700 (PDT) Received: from m2.. ([37.142.145.227]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-48e71b959c1sm5457300f8f.45.2026.10.30.15.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2026 15:37:06 -0700 (PDT) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH v2 04/15] HID: ft260: i2c: reduce driver module loading time Date: Sat, 31 Oct 2026 00:36:26 +0200 Message-ID: <20261030223637.86907-5-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261030223637.86907-1-michael.zaidman@gmail.com> References: <20261030223637.86907-1-michael.zaidman@gmail.com> X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The HWMON class I2C client drivers register the address range to scan during the I2C master module probing. For example, the lm75 module registers eight bus addresses scanned during the ft260 module loading. In the case of ft260, the bus is scanned by ft260_i2c_read, but due to an excessive read completion timeout, it took about 40 seconds for the ft260 driver to scan the lm75 address range before exiting the probe function. Adjust the i2c_read timeout so it depends on the amount of data to read, reducing the lm75 address range scan time to about 200ms. The 25 ms per-report budget was checked on a UMFT260EV1A with a 24LC512 EEPROM by shrinking the timeout until reads began to fail: a 60-byte read still completes at 9 ms and times out at 7 ms, against 5.4 ms of wire time at 100 kHz, so the fixed USB, HID and scheduling overhead costs a few milliseconds. At the chip's slowest 60 kHz clock that chunk needs about 9 ms on the wire and a 180-byte chunk about 27 ms. Scale the wait by 25 ms per 60-byte HID payload so a last chunk of 61..180 bytes gets 50..75 ms, not the single-report 25 ms budget (reported by Sashiko). Signed-off-by: Michael Zaidman --- v2: last I2C read chunk timeout from rd_len (reported by Sashiko). --- drivers/hid/hid-ft260.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index e24f3151fdaf..f134fab08285 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -49,14 +50,20 @@ MODULE_PARM_DESC(debug, "Toggle FT260 debugging messages"); * The ft260 input report format defines 62 bytes for the data payload, but * when requested 62 bytes, the controller returns 60 and 2 in separate input * reports. To achieve better performance with the multi-report read data - * transfers, we set the maximum read payload length to a multiple of 60. + * transfers, we set the maximum read payload length to a multiple of + * FT260_RD_ONE_REPORT_MAX. * With a 100 kHz I2C clock, one 240 bytes read takes about 1/27 second, * which is excessive; On the other hand, some higher layer drivers like at24 * or optoe limit the i2c reads to 128 bytes. To not block other drivers out * of I2C for potentially troublesome amounts of time, we select the maximum * read payload length to be 180 bytes. */ +#define FT260_RD_ONE_REPORT_MAX 60 #define FT260_RD_DATA_MAX 180 + +/* Time in ms to wait for a single HID input report at ONE_REPORT_MAX */ +#define FT260_RD_ONE_REPORT_TO 25 + #define FT260_WR_I2C_DATA_MAX 60 #define FT260_WR_UART_DATA_MAX 62 #define FT260_GPIOCHIP "ft260_gpio" @@ -722,8 +729,8 @@ static int ft260_i2c_read(struct ft260_device *dev, u8 addr, u8 *data, u16 len, u8 flag) { u16 rd_len; - u16 rd_data_max = 60; - int timeout, ret = 0; + u16 rd_data_max = FT260_RD_ONE_REPORT_MAX; + int timeout, timeout_jiffies, ret = 0; struct ft260_i2c_read_request_report rep; struct hid_device *hdev = dev->hdev; unsigned long irqflags; @@ -748,6 +755,8 @@ static int ft260_i2c_read(struct ft260_device *dev, u8 addr, u8 *data, } else { rd_len = rd_data_max; } + timeout = FT260_RD_ONE_REPORT_TO * + DIV_ROUND_UP(rd_len, FT260_RD_ONE_REPORT_MAX); rd_data_max = FT260_RD_DATA_MAX; rep.report = FT260_I2C_READ_REQ; @@ -772,8 +781,8 @@ static int ft260_i2c_read(struct ft260_device *dev, u8 addr, u8 *data, goto ft260_i2c_read_exit; } - timeout = msecs_to_jiffies(5000); - if (!wait_for_completion_timeout(&dev->wait, timeout)) { + timeout_jiffies = msecs_to_jiffies(timeout); + if (!wait_for_completion_timeout(&dev->wait, timeout_jiffies)) { ret = -ETIMEDOUT; ft260_i2c_reset(hdev); goto ft260_i2c_read_exit; -- 2.43.0