From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794945924; b=cx1DFksUtQlB3PqlonyXIo7XySs1Qhl6mejucOOePNt4t/ayMe3zojuLPc5QwWQKTTI2 ieCZqPcwyyd2PmOsvQVTYAXx/ZB95BZXmS2B+RLwxHNUQAnWGMgk/1Bs4+f7VC+8ViRCH 07G+VLzrQ5M3gsn7R+JqJZfg1fs2HnHh7GEMnFRK6vfBB/0Lj2KbAFYETpJpxY1tuxmUG mGi/f/kDPDRk4y1z/47T0fRCdMwaMDnaaNTqO/9RUUWTRvFZXxHYZxAZ1ayf34GRg4f+3 qiNv6a/4XlsXO1hhmyHI/Vxtz+Q6JNmRGlcs9VPGf6xyrywATZCN9nV1r5gTdZB9NRA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794945924; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=F4uXxJokLeEK2Ei4CenpFZ/AW+5FOpcgkJGIO2nPRlY=; b=LFA1XBu9P924x+Wdor1jk8ehwfZra0YmIuOqMGlm1UmLscQ918OBOW7Iu+62X0XS1VYK wMhVIB9NCqf5J5sysmL2xKB8sWbOW/XetYOkBXyn8BQoMC4k0Kpa8GN8JVfsvP3NskTRW II3smY5I9YGYit4sRG0bk+L5Uk3CTgLhdtDiHtdghyIl3MEquU2C6cOLeqCK14gTUjJrS Aq5Q8o6KneeELrRyY3W6hTOFT1+r3HI/aXw6Ql6h1sanmfQnzAI55e61+ubJx9DuDzgPk QDaAeBrMr7HrcuT6o5VHTjeM1QVepgW/gn4cD/t3o9kglruulLiwaFWOwJhq53siwcg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=cnVZ8soi; arc=none smtp.remote-ip=209.85.221.53 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3C77606C70D for ; Tue, 17 Nov 2026 20:05:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A3C77606C70D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=cnVZ8soi Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-498f5fa4f70so158725f8f.0 for ; Tue, 17 Nov 2026 12:05:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794945922; x=1795550722; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=F4uXxJokLeEK2Ei4CenpFZ/AW+5FOpcgkJGIO2nPRlY=; b=cnVZ8soiaMC68w3xaXt7hxACf295vu4LUFyBx5IHqKhXUO78ZqV6xWjnSubsdr3KSB ekFoJa4dZDSEbQzYp3JLhoiPoLtfuR27Zf4IdAiQsfP2capDCYVi/i2Z6/IomVwMYAXC xM/M3yo/DCcExZg5rDrMDauNVzbEm8zmCQ4edQq+Dle2bRk3VHBTyIJw7Lsfn5HFVeH9 Zaa7OPjyogaYgJinHjluak0k9IrI+Zv6VAUvGiVEJLsthcBi58qwutZtBmcRsvex+Hli yOlZMolCnZ3Ib6lMvsbGeMkEorRrrPrCNxywqz+a51GUuiLKhdCZ45l6e10JivZqRjKM tq9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794945922; x=1795550722; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=F4uXxJokLeEK2Ei4CenpFZ/AW+5FOpcgkJGIO2nPRlY=; b=It1UyCRgAxA7t01aXDF+pQCo+Rpu4O1bqgoO8B3hMjNWG/j0x3w7E3CiDF7Ku0AbRe /tX9fmf9sTITcZIO58SFc9C4w35PumXLlbT1EljBxKgP1eiLFD3lZHURV5Fg2vtfHapz o4loAYnY977GNrUT6vBm1q3Obgm3ftxHAspJG8EBvj4YbZi0TVeMqugc8soy/MzF5gkY 3U3h7cjTCW7LwzuhCoq4AX1X0EUFIl9LVTKmGFdBv/BF8TsU+tlENcJkAZ9U08WnBhkh kawL73oQbWdO9Jq/WfSFQ2iRXaOqD30PbntHldEhfEhF0Bje11v0AVjRXPNPP//Gusim pZig== X-Forwarded-Encrypted: i=1; AL+hErFcUyAtReRgkyrAAWsSLqN6I5l16DgFjgoz2zp/iW2KhdjWXNp9gqj16jsVeyRt3jZlCR8r7m9THFZxVbc=@vger.kernel.org X-Gm-Message-State: APuU4Z/+Ex9RQ54/8j8N+38k42fdSTkrs8DRGCdKylCOnHtHDJHNQPcr /J/S8+NzrNQiJCCMm3c/AFn3ohzJSUGL2t9TA7J71VS5LcjsVEkHlVzD X-Gm-Gg: AZFdTZfCQfTVapTppb+gBx14if25RIJNTz66pn71aoWMeuwqD13UdmsHAEAv2DMGEyO ii4El8A/AguJuZYeSB3vp1rA8VWNMNyh9uAZznAlC3K3okB0McPc1Xv9LNzXfRs7odH5z6trdRE cXLoHMdKcQPadIxEB4a6Pj2rp22rHI/vBKkhZRUOzVA1obIKR7Hg4n8rhgqLKgz5dx10xIs4/xG b/ryoydWQeE3JrXQnNP+zBM0dJ/xyZ78raHoIz2Ys41jO3X2MltmyDz17/LzWDvikMcIuPnN0NK Q5Uh2cs4pFHAY1DvQANMJDJ6UtEKFNe6bFTVid0yfR2PksjYrgs72uDcjNPQllK16kDEzmxlWPi OMt2dEQRXR52WCgwhBxFa6VOp8CKLDsUEF/g7yGGD029H24i+ZQib9xIPKkzhkbfaa9D/5F+asB IJ8KmJ4IV9DImBbJr11Qvz1hDUuUmvonXgOvSeMJe5PLSISO3v2t6qaK11lHgKJ7ImPrNq6hcgK AQiB5lDdttgLA1L2DLRKrXrDGcg01mQj2HHNOuFbKc6ckUiv66hM1JnECB8HjkPM22vqRdrzT30 Tim0RlFbCQd2NHxYxzAGt8/mM6Fn X-Received: by 2002:a05:6000:2990:10b0:48e:870:7791 with SMTP id ffacd0b85a97d-4a63ac6b6b0mr839568f8f.26.1794945921835; Tue, 17 Nov 2026 12:05:21 -0800 (PST) Received: from m2.. ([37.142.154.208]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-4a64b60940csm625528f8f.0.2026.11.17.12.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2026 12:05:21 -0800 (PST) From: Michael Zaidman To: Jiri Kosina , Benjamin Tissoires Cc: Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , Jiri Slaby , Raman Varabets , Germain Hebert , Christina Quast , Rio Liu , Bruno Giacomazzi , linux-input@vger.kernel.org, linux-serial@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Zaidman Subject: [PATCH v4 09/16] HID: ft260: group sysfs attrs per HID interface Date: Tue, 17 Nov 2026 22:04:15 +0200 Message-ID: <20261117200423.19561-10-michael.zaidman@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261117200423.19561-1-michael.zaidman@gmail.com> References: <20261117200423.19561-1-michael.zaidman@gmail.com> X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Split the single sysfs attribute group into per-interface groups based on chip mode (DCNF0/DCNF1): - I2C-only (mode 1): I2C and GPIO attributes on the I2C HID interface - Dual mode (0/3): hid_over_i2c_en, i2c_reset and clock on the I2C interface; GPIO and UART attrs on the UART interface - UART-only (mode 2): GPIO and UART attrs on the UART interface i2c_enable is GPIO-related too: it switches GPIO0 and GPIO1 between I2C and GPIO, and its store updates gpio_en of its own interface. So it is on the interface with the gpiochip, the UART interface in modes 0 and 3. i2c_reset is an I2C attribute, so it is only on the I2C interface and not in the UART group, which holds the GPIO and UART attributes. Signed-off-by: Michael Zaidman --- v2: Fixes for the issues reported by Sashiko: - The i2c_enable attribute was missing in modes 0 and 3; it is now in the UART group, with the gpiochip. - The i2c_reset attribute, an I2C attribute, is no longer in the UART group. v3: The err_register_tty path, which patch 3 adds to ft260_uart_probe(), removes the UART attribute group of this patch. --- drivers/hid/hid-ft260.c | 63 ++++++++++++++++++++++++++++++++++------- 1 file changed, 53 insertions(+), 10 deletions(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index eeaf8179adcc..e34780c62522 100644 --- a/drivers/hid/hid-ft260.c +++ b/drivers/hid/hid-ft260.c @@ -1633,7 +1633,7 @@ static ssize_t i2c_reset_store(struct device *kdev, } static DEVICE_ATTR_WO(i2c_reset); -static const struct attribute_group ft260_attr_group = { +static const struct attribute_group ft260_i2c_chip_mode_1_attr_group = { .attrs = (struct attribute *[]) { &dev_attr_chip_mode.attr, &dev_attr_pwren_status.attr, @@ -1644,8 +1644,6 @@ static const struct attribute_group ft260_attr_group = { &dev_attr_gpio2_func.attr, &dev_attr_gpioa_func.attr, &dev_attr_gpiog_func.attr, - &dev_attr_uart_mode.attr, - &dev_attr_uart_dcd_ri.attr, &dev_attr_clock_ctl.attr, &dev_attr_i2c_reset.attr, &dev_attr_clock.attr, @@ -1653,6 +1651,32 @@ static const struct attribute_group ft260_attr_group = { } }; +static const struct attribute_group ft260_i2c_chip_mode_0_3_attr_group = { + .attrs = (struct attribute *[]) { + &dev_attr_hid_over_i2c_en.attr, + &dev_attr_i2c_reset.attr, + &dev_attr_clock.attr, + NULL + } +}; + +static const struct attribute_group ft260_uart_chip_mode_0_2_3_attr_group = { + .attrs = (struct attribute *[]) { + &dev_attr_chip_mode.attr, + &dev_attr_pwren_status.attr, + &dev_attr_suspend_status.attr, + &dev_attr_power_saving_en.attr, + &dev_attr_i2c_enable.attr, + &dev_attr_gpio2_func.attr, + &dev_attr_gpioa_func.attr, + &dev_attr_gpiog_func.attr, + &dev_attr_uart_mode.attr, + &dev_attr_uart_dcd_ri.attr, + &dev_attr_clock_ctl.attr, + NULL + } +}; + static DEFINE_MUTEX(ft260_uart_list_lock); static LIST_HEAD(ft260_uart_device_list); @@ -2372,11 +2396,20 @@ static int ft260_i2c_probe(struct ft260_device *dev, if (ret) goto err_i2c_free; - ret = sysfs_create_group(&hdev->dev.kobj, &ft260_attr_group); + ret = sysfs_create_group(&hdev->dev.kobj, + &ft260_i2c_chip_mode_1_attr_group); if (ret < 0) { hid_err(hdev, "failed to create sysfs attrs\n"); goto err_gpio_remove; } + } else if (cfg->chip_mode == FT260_MODE_ALL || + cfg->chip_mode == FT260_MODE_BOTH) { + ret = sysfs_create_group(&hdev->dev.kobj, + &ft260_i2c_chip_mode_0_3_attr_group); + if (ret < 0) { + hid_err(hdev, "failed to create sysfs attrs\n"); + goto err_i2c_free; + } } return 0; @@ -2432,12 +2465,14 @@ static int ft260_uart_probe(struct ft260_device *dev, cfg->uart_mode = FT260_UART_CFG_FLOW_CTRL_NONE; if (dev->chip_mode & FT260_MODE_UART || - dev->chip_mode == FT260_MODE_ALL) { + dev->chip_mode == FT260_MODE_ALL || + dev->chip_mode == FT260_MODE_BOTH) { ret = ft260_gpio_init(dev, cfg); if (ret) goto err_hid_report; - ret = sysfs_create_group(&hdev->dev.kobj, &ft260_attr_group); + ret = sysfs_create_group(&hdev->dev.kobj, + &ft260_uart_chip_mode_0_2_3_attr_group); if (ret < 0) { hid_err(hdev, "failed to create sysfs attrs\n"); goto err_gpio_remove; @@ -2460,7 +2495,8 @@ static int ft260_uart_probe(struct ft260_device *dev, err_register_tty: if (dev->gc.parent) - sysfs_remove_group(&hdev->dev.kobj, &ft260_attr_group); + sysfs_remove_group(&hdev->dev.kobj, + &ft260_uart_chip_mode_0_2_3_attr_group); err_gpio_remove: if (dev->gc.parent) gpiochip_remove(&dev->gc); @@ -2569,11 +2605,18 @@ static void ft260_remove(struct hid_device *hdev) dev->index); ft260_uart_port_remove(dev); if (dev->chip_mode & FT260_MODE_UART || - dev->chip_mode == FT260_MODE_ALL) - sysfs_remove_group(&hdev->dev.kobj, &ft260_attr_group); + dev->chip_mode == FT260_MODE_ALL || + dev->chip_mode == FT260_MODE_BOTH) + sysfs_remove_group(&hdev->dev.kobj, + &ft260_uart_chip_mode_0_2_3_attr_group); } else { if (dev->chip_mode == FT260_MODE_I2C) - sysfs_remove_group(&hdev->dev.kobj, &ft260_attr_group); + sysfs_remove_group(&hdev->dev.kobj, + &ft260_i2c_chip_mode_1_attr_group); + else if (dev->chip_mode == FT260_MODE_ALL || + dev->chip_mode == FT260_MODE_BOTH) + sysfs_remove_group(&hdev->dev.kobj, + &ft260_i2c_chip_mode_0_3_attr_group); i2c_del_adapter(&dev->adap); } -- 2.43.0