From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Diogo Ivo <diogo.ivo.sx@renesas.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Thierry Bultel <thierry.bultel.yh@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>,
stable@vger.kernel.org
Subject: Re: [PATCH mainline-linux 1/4] tty: serial: sh-sci: set the RSCI RX FIFO trigger to half the FIFO
Date: Fri, 20 Nov 2026 17:11:52 +0100 [thread overview]
Message-ID: <2026112012-aftermath-trench-f567@gregkh> (raw)
In-Reply-To: <20261120-divo-ssgrlpcsrc-2996-rs485-v1-1-a989baae3559@renesas.com>
On Fri, Nov 20, 2026 at 03:49:24PM +0000, Diogo Ivo wrote:
> From: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
>
> The RSCI port types ask for a RX FIFO trigger equal to their FIFO size,
> which rsci_scif_set_rtrg() clamps to fifosize - 1. RDRF is raised once
> the FIFO holds at least RTRG bytes, so the receive interrupt arrives
> with a single byte of space left, causing overruns at 1152000 baud on
> RZ/T2H, and at 115200 baud on RZ/G3L.
>
> Every other port with a FIFO triggers at half of it, SCIF at 8 of 16 and
> HSCIF at 64 of 128. The only exceptions are SCIFA and SCIFB which set it
> to 1 because they have no hardware FIFO timeout and a higher trigger
> would leave bytes in the FIFO.
>
> Trigger at half the FIFO for RSCI as well, 8 of 16 for RSCI_PORT_SCIF16
> and 16 of 32 for the RSCI_PORT_SCIF32 types.
>
> Cc: stable@vger.kernel.org
> Fixes: 3a3ab10245b6 ("serial: sh-sci: Update rx_trigger size for RZ/T2H RSCI")
> Fixes: 0666e3fe95ab ("serial: sh-sci: Add support for RZ/T2H SCI")
> Fixes: 42eeed6d9f31 ("serial: sh-sci: Add support for RZ/G3E RSCI")
> Fixes: 8f18d3cbd920 ("serial: sh-sci: Add support for RZ/G3L RSCI")
So this patch is going to fail to apply to 6.18.y, which from this list
looks like you want it to apply to. So please break it up into
one-patch-per-device to make it simpler for everyone involved.
thanks,
greg k-h
next prev parent reply other threads:[~2026-11-20 16:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 15:49 [PATCH mainline-linux 0/4] serial: sh-sci: rsci: Add RS485 support Diogo Ivo
2026-11-20 15:49 ` [PATCH mainline-linux 1/4] tty: serial: sh-sci: set the RSCI RX FIFO trigger to half the FIFO Diogo Ivo
2026-11-20 16:11 ` Greg Kroah-Hartman [this message]
2026-11-20 15:49 ` [PATCH mainline-linux 2/4] dt-bindings: serial: renesas,rsci: Document RS485 properties Diogo Ivo
2026-11-20 15:49 ` [PATCH mainline-linux 3/4] serial: sh-sci: rsci: Add RS485 support Diogo Ivo
2026-11-20 15:49 ` [PATCH mainline-linux 4/4] arm64: dts: renesas: r9a08g046l48-smarc: Add RS485 support on RSCI2 Diogo Ivo
2026-11-20 16:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026112012-aftermath-trench-f567@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=cosmin-gabriel.tanislav.xa@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo.sx@renesas.com \
--cc=geert+renesas@glider.be \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=thierry.bultel.yh@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox