From: Stefan Wahren <stefan.wahren@i2se.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: gregkh@linuxfoundation.org, phil@raspberrypi.org,
linux-serial@vger.kernel.org, jslaby@suse.com,
loic.poulain@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty: amba-pl011: Report AUTOCTS capability to framework
Date: Tue, 31 Oct 2017 00:46:53 +0100 (CET) [thread overview]
Message-ID: <2129655909.63812.1509407213334@email.1und1.de> (raw)
In-Reply-To: <20171030233228.GA3183@wunner.de>
Hi Lukas,
> Lukas Wunner <lukas@wunner.de> hat am 31. Oktober 2017 um 00:32 geschrieben:
>
>
> On Mon, Oct 30, 2017 at 11:24:31PM +0000, Stefan Wahren wrote:
> > --- a/drivers/tty/serial/amba-pl011.c
> > +++ b/drivers/tty/serial/amba-pl011.c
> > @@ -2029,9 +2029,11 @@ pl011_set_termios(struct uart_port *port, struct ktermios *termios,
> >
> > old_cr |= UART011_CR_CTSEN;
> > uap->autorts = true;
> > + port->status |= UPSTAT_AUTOCTS;
> > } else {
> > old_cr &= ~(UART011_CR_CTSEN | UART011_CR_RTSEN);
> > uap->autorts = false;
> > + port->status &= ~UPSTAT_AUTOCTS;
> > }
> >
> > if (uap->vendor->oversampling) {
>
> Don't you also need to clear the UPSTAT_AUTOCTS bit in pl011_disable_uart()?
>
> FWIW I posted a patch to linux-serial on Oct 25 which subsumes the above
> patch, would that work for you?
>
> https://marc.info/?l=linux-serial&m=150891880104614&w=4
sorry for missing your patch. Mine should be ignored.
>
> Thanks,
>
> Lukas
prev parent reply other threads:[~2017-10-30 23:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 13:03 [PATCH] tty: amba-pl011: Report AUTOCTS capability to framework Stefan Wahren
[not found] ` <20171030233228.GA3183@wunner.de>
2017-10-30 23:46 ` Stefan Wahren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2129655909.63812.1509407213334@email.1und1.de \
--to=stefan.wahren@i2se.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=loic.poulain@gmail.com \
--cc=lukas@wunner.de \
--cc=phil@raspberrypi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox