From: Yuriy Kozlov <ykozlov@ptcusa.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Tobias Klauser <tklauser@distanz.ch>,
Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: altera_uart: Check for NULL platform_data in probe.
Date: Thu, 29 Mar 2012 16:02:07 -0400 [thread overview]
Message-ID: <2271072.B4UpndiPVz@hyrum> (raw)
In-Reply-To: <20120329194711.GB12194@kroah.com>
On Thursday, March 29, 2012 12:47:11 Greg Kroah-Hartman wrote:
> On Thu, Mar 29, 2012 at 09:38:55PM +0200, Tobias Klauser wrote:
> > On 2012-03-29 at 18:13:37 +0200, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> > > On Thu, Mar 29, 2012 at 09:55:27AM +0200, Tobias Klauser wrote:
> > > > From: Yuriy Kozlov <ykozlov@ptcusa.com>
> > > >
> > > > Follow altera_jtag_uart. This fixes a crash if there is a mistake in
> > > > the DTS.> >
> > > Is this something you have seen in the wild? Is this something to be
> > > backported to stable kernels?
> >
> > Not that I know of. But nevertheless it might be worthwhile. Shall I
> > send the patch again with Cc: stable@kernel.org?
>
> Nope, I can add it.
>
> But, if this isn't something that you have seen, why is it needed to be
> checked for? What is this making work properly that isn't working
> properly now?
>
> thanks,
>
> greg k-h
The driver is designed to use Device Tree to get hardware information, so
platp (platform_data) is usually NULL. platform_data is still used as a
fallback mechanism. The problem arises when the device is in the DT, but is
missing a required property (address or irq). The driver falls back to
looking for it in the null platp and panics. The function actually already
checks platp for other properties later on, but under this condition it tried
to dereference it before the null checks.
--
~ Yuriy Kozlov
Pyramid Technical Consultants, Inc.
---------------------------------------------------------
next prev parent reply other threads:[~2012-03-29 21:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 7:55 [PATCH] tty: serial: altera_uart: Check for NULL platform_data in probe Tobias Klauser
2012-03-29 16:13 ` Greg Kroah-Hartman
2012-03-29 19:38 ` Tobias Klauser
2012-03-29 19:47 ` Greg Kroah-Hartman
2012-03-29 20:02 ` Yuriy Kozlov [this message]
2012-03-29 21:39 ` Greg Kroah-Hartman
2012-03-30 6:32 ` Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2271072.B4UpndiPVz@hyrum \
--to=ykozlov@ptcusa.com \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox