linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] serial: stm32: fix build failure
@ 2016-10-06  9:33 Alexandre TORGUE
  2016-10-06 14:09 ` Alexandre Torgue
  0 siblings, 1 reply; 2+ messages in thread
From: Alexandre TORGUE @ 2016-10-06  9:33 UTC (permalink / raw)
  To: Maxime Coquelin, gerald.baeza, Greg Kroah-Hartman, Jiri Slaby
  Cc: linux-serial, linux-arm-kernel

While building m32r config the build failed with:
ERROR: stm32-usart.c:(.text+0xdc988): undefined reference to `bad_dma_ops'

To satisfy the dependency CONFIG_SERIAL_STM32 should depend on HAS_DMA.

Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index c783140..8a261c0 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1624,6 +1624,7 @@ config SERIAL_SPRD_CONSOLE
 
 config SERIAL_STM32
 	tristate "STMicroelectronics STM32 serial port support"
+	depends on HAS_DMA
 	select SERIAL_CORE
 	depends on ARM || COMPILE_TEST
 	help
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] serial: stm32: fix build failure
  2016-10-06  9:33 [PATCH -next] serial: stm32: fix build failure Alexandre TORGUE
@ 2016-10-06 14:09 ` Alexandre Torgue
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Torgue @ 2016-10-06 14:09 UTC (permalink / raw)
  To: Maxime Coquelin, gerald.baeza, Greg Kroah-Hartman, Jiri Slaby
  Cc: linux-arm-kernel, linux-serial

Hi,


On 10/06/2016 11:33 AM, Alexandre TORGUE wrote:
> While building m32r config the build failed with:
> ERROR: stm32-usart.c:(.text+0xdc988): undefined reference to `bad_dma_ops'
>
> To satisfy the dependency CONFIG_SERIAL_STM32 should depend on HAS_DMA.
>
> Signed-off-by: Alexandre TORGUE <alexandre.torgue@st.com>
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index c783140..8a261c0 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1624,6 +1624,7 @@ config SERIAL_SPRD_CONSOLE
>
>  config SERIAL_STM32
>  	tristate "STMicroelectronics STM32 serial port support"
> +	depends on HAS_DMA
>  	select SERIAL_CORE
>  	depends on ARM || COMPILE_TEST
>  	help
>
Same patch has been sent in same time. Please abandon this one.

Regards
Alex

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-06 14:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-06  9:33 [PATCH -next] serial: stm32: fix build failure Alexandre TORGUE
2016-10-06 14:09 ` Alexandre Torgue

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).