From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/4] serial: pch_uart: Delete an error message for a failed memory allocation in dma_handle_tx()
Date: Fri, 8 Dec 2017 19:09:26 +0100 [thread overview]
Message-ID: <2378ba53-4894-e532-7523-b578e42c8eb2@users.sourceforge.net> (raw)
In-Reply-To: <f8220e08-da4c-65d6-ecc7-9405cab6f375@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 8 Dec 2017 18:28:20 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/tty/serial/pch_uart.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
index 760d5dd0aada..0fc72c491c9b 100644
--- a/drivers/tty/serial/pch_uart.c
+++ b/drivers/tty/serial/pch_uart.c
@@ -992,10 +992,8 @@ static unsigned int dma_handle_tx(struct eg20t_port *priv)
priv->tx_dma_use = 1;
priv->sg_tx_p = kzalloc(sizeof(struct scatterlist)*num, GFP_ATOMIC);
- if (!priv->sg_tx_p) {
- dev_err(priv->port.dev, "%s:kzalloc Failed\n", __func__);
+ if (!priv->sg_tx_p)
return 0;
- }
sg_init_table(priv->sg_tx_p, num); /* Initialize SG table */
sg = priv->sg_tx_p;
--
2.15.1
next prev parent reply other threads:[~2017-12-08 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 18:08 [PATCH 0/4] tty/serial/pch_uart: Adjustments for four function implementations SF Markus Elfring
2017-12-08 18:09 ` SF Markus Elfring [this message]
2017-12-08 18:10 ` [PATCH 2/4] serial: pch_uart: Use kcalloc() in dma_handle_tx() SF Markus Elfring
2017-12-08 18:11 ` [PATCH 3/4] serial: pch_uart: Delete an unnecessary return statement in two functions SF Markus Elfring
2017-12-08 18:12 ` [PATCH 4/4] serial: pch_uart: Improve a size determination in pch_uart_init_port() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2378ba53-4894-e532-7523-b578e42c8eb2@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).