* [PATCH 2/3] serial: xuartps: Enable OF earlycon support [not found] <67c9013fc61f53515934b54847a05df8b8e1504a.1455552315.git.michal.simek@xilinx.com> @ 2016-02-15 16:05 ` Michal Simek 2016-02-16 11:54 ` Arnd Bergmann 2016-02-16 16:33 ` Peter Hurley 0 siblings, 2 replies; 5+ messages in thread From: Michal Simek @ 2016-02-15 16:05 UTC (permalink / raw) To: linux-arm-kernel, Arnd Bergmann, Nicolas Pitre Cc: Sören Brinkmann, monstr, Jiri Slaby, linux-kernel, linux-serial, Greg Kroah-Hartman Support early console setup via DT for all listed compatible strings. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 009e0dbc12d2..6f5657766815 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1094,6 +1094,9 @@ static int __init cdns_early_console_setup(struct earlycon_device *device, return 0; } EARLYCON_DECLARE(cdns, cdns_early_console_setup); +OF_EARLYCON_DECLARE(cdns_a, "xlnx,xuartps", cdns_early_console_setup); +OF_EARLYCON_DECLARE(cdns_b, "cdns,uart-r1p8", cdns_early_console_setup); +OF_EARLYCON_DECLARE(cdns_c, "cdns,uart-r1p12", cdns_early_console_setup); /** * cdns_uart_console_write - perform write operation -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support 2016-02-15 16:05 ` [PATCH 2/3] serial: xuartps: Enable OF earlycon support Michal Simek @ 2016-02-16 11:54 ` Arnd Bergmann 2016-02-16 16:33 ` Peter Hurley 1 sibling, 0 replies; 5+ messages in thread From: Arnd Bergmann @ 2016-02-16 11:54 UTC (permalink / raw) To: linux-arm-kernel Cc: Michal Simek, Nicolas Pitre, monstr, Greg Kroah-Hartman, linux-kernel, linux-serial, Jiri Slaby, Sören Brinkmann On Monday 15 February 2016 17:05:18 Michal Simek wrote: > Support early console setup via DT for all listed compatible strings. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > I'd suggest we take the whole series through arm-soc, as the third patch depends on this second one. Greg, is this ok for you? Arnd ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support 2016-02-15 16:05 ` [PATCH 2/3] serial: xuartps: Enable OF earlycon support Michal Simek 2016-02-16 11:54 ` Arnd Bergmann @ 2016-02-16 16:33 ` Peter Hurley 2016-02-18 8:01 ` Michal Simek 1 sibling, 1 reply; 5+ messages in thread From: Peter Hurley @ 2016-02-16 16:33 UTC (permalink / raw) To: Michal Simek, linux-arm-kernel, Arnd Bergmann, Nicolas Pitre Cc: Sören Brinkmann, monstr, Jiri Slaby, linux-kernel, linux-serial, Greg Kroah-Hartman Hi Michal, On 02/15/2016 08:05 AM, Michal Simek wrote: > Support early console setup via DT for all listed compatible strings. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > drivers/tty/serial/xilinx_uartps.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c > index 009e0dbc12d2..6f5657766815 100644 > --- a/drivers/tty/serial/xilinx_uartps.c > +++ b/drivers/tty/serial/xilinx_uartps.c > @@ -1094,6 +1094,9 @@ static int __init cdns_early_console_setup(struct earlycon_device *device, > return 0; > } > EARLYCON_DECLARE(cdns, cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns_a, "xlnx,xuartps", cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns_b, "cdns,uart-r1p8", cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns_c, "cdns,uart-r1p12", cdns_early_console_setup); Earlycon now shares a common framework in linux-next. The EARLYCON_DECLARE() can be deleted and the OF_EARLYCON_DECLARE() can all share the same earlycon name. iow, -EARLYCON_DECLARE(cdns, cdns_early_console_setup); +OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup); +OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup); +OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup); Regards, Peter Hurley > /** > * cdns_uart_console_write - perform write operation > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support 2016-02-16 16:33 ` Peter Hurley @ 2016-02-18 8:01 ` Michal Simek 2016-02-18 17:20 ` Peter Hurley 0 siblings, 1 reply; 5+ messages in thread From: Michal Simek @ 2016-02-18 8:01 UTC (permalink / raw) To: Peter Hurley, Michal Simek, linux-arm-kernel, Arnd Bergmann, Nicolas Pitre Cc: monstr, Greg Kroah-Hartman, linux-kernel, linux-serial, Jiri Slaby, Sören Brinkmann Hi Peter, On 16.2.2016 17:33, Peter Hurley wrote: > Hi Michal, > > On 02/15/2016 08:05 AM, Michal Simek wrote: >> Support early console setup via DT for all listed compatible strings. >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> >> --- >> >> drivers/tty/serial/xilinx_uartps.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c >> index 009e0dbc12d2..6f5657766815 100644 >> --- a/drivers/tty/serial/xilinx_uartps.c >> +++ b/drivers/tty/serial/xilinx_uartps.c >> @@ -1094,6 +1094,9 @@ static int __init cdns_early_console_setup(struct earlycon_device *device, >> return 0; >> } >> EARLYCON_DECLARE(cdns, cdns_early_console_setup); >> +OF_EARLYCON_DECLARE(cdns_a, "xlnx,xuartps", cdns_early_console_setup); >> +OF_EARLYCON_DECLARE(cdns_b, "cdns,uart-r1p8", cdns_early_console_setup); >> +OF_EARLYCON_DECLARE(cdns_c, "cdns,uart-r1p12", cdns_early_console_setup); > > Earlycon now shares a common framework in linux-next. > > The EARLYCON_DECLARE() can be deleted and the OF_EARLYCON_DECLARE() > can all share the same earlycon name. iow, > > -EARLYCON_DECLARE(cdns, cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup); I have sent v2 and I have tested it. All looks good. Thanks for pointing me to that change. BTW: Is it normal that when earlycon support is enabled that the bootlog is copied again? All what was printed before bootconsole [xxx] disabled is printed twice. Or is this just bug in our driver? Thanks, Michal ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support 2016-02-18 8:01 ` Michal Simek @ 2016-02-18 17:20 ` Peter Hurley 0 siblings, 0 replies; 5+ messages in thread From: Peter Hurley @ 2016-02-18 17:20 UTC (permalink / raw) To: Michal Simek, linux-arm-kernel, Arnd Bergmann, Nicolas Pitre Cc: Sören Brinkmann, monstr, Jiri Slaby, linux-kernel, linux-serial, Greg Kroah-Hartman On 02/18/2016 12:01 AM, Michal Simek wrote: > BTW: Is it normal that when earlycon support is enabled that the bootlog > is copied again? All what was printed before bootconsole [xxx] disabled > is printed twice. I think it has to do with the dummy console bug w/ OF. Masahiro Yamada reported this back with 4.4-rc1 [1] but problem occurs before then as well. [1] http://www.gossamer-threads.com/lists/linux/kernel/2313050 > Or is this just bug in our driver? No. Regards, Peter Hurley ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-18 17:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <67c9013fc61f53515934b54847a05df8b8e1504a.1455552315.git.michal.simek@xilinx.com>
2016-02-15 16:05 ` [PATCH 2/3] serial: xuartps: Enable OF earlycon support Michal Simek
2016-02-16 11:54 ` Arnd Bergmann
2016-02-16 16:33 ` Peter Hurley
2016-02-18 8:01 ` Michal Simek
2016-02-18 17:20 ` Peter Hurley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).