Re: [PATCH v5 2/4] serial: 8250_dw: build Renesas RZN1 CPR value from DW_UART_CPR_* definitions

Andy Shevchenko
2026-04-29T09:05:38Z

On Wed, Apr 29, 2026 at 08:56:45AM +0800, Jia Wang wrote:
> On 2026-04-28 13:58 +0300, Andy Shevchenko wrote:
> > On Tue, Apr 28, 2026 at 05:07:49PM +0800, Jia Wang wrote:
> > > On 2026-04-28 11:41 +0300, Ilpo Järvinen wrote:

...

> > > Thanks. I tried that approach, but the statement-expression form does
> > > not work in this case because the helper is used in static initializers.
> > > So I'll keep it as a plain expression macro for now, and just rework it
> > > into a cleaner multi-line form.
> >
> > Still you can move FIELD_PREP_CONST() into it.
>
> Right, I'll move FIELD_PREP_CONST() in. By the way, does your Reviewed-by
> still hold?

Not for this patch, as it seems we get too many modifications and discussions
around. Let have a fresh look in v6 (the rest of the patches are okay, please
keep tags there).

--
With Best Regards,
Andy Shevchenko