Re: [PATCH 3/4] arm64: dts: rockchip: Add base DT for rk3528 SoC

Krzysztof Kozlowski
2024-08-04T14:05:31Z

On 04/08/2024 15:20, Yao Zi wrote:
>>
>>> + compatible = "fixed-clock";
>>> + #clock-cells = <0>;
>>> + clock-frequency = <24000000>;
>>> + clock-output-names = "xin24m";
>>> + };
>>> +
>>> + gic: interrupt-controller@fed01000 {
>>
>> Why this all is outside of SoC?
>
> Just as Heiko says, device tree for all other Rockchip SoCs don't have
> a "soc" node. I didn't know why before but just follow the style.
>
> If you prefer add a soc node, I am willing to.

Surprising as usually we expect MMIO nodes being part of SoC to be under
soc@, but if that's Rockchip preference then fine.

Best regards,
Krzysztof