From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Benjamin Larsson <benjamin.larsson@genexis.eu>,
John Ogness <john.ogness@linutronix.de>,
Marco Felsch <m.felsch@pengutronix.de>,
Gerhard Engleder <eg@keba.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Randy Dunlap <rdunlap@infradead.org>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Rong Zhang <rongrong@oss.cipunited.com>,
Lukas Wunner <lukas@wunner.de>, Lubomir Rintel <lkundrak@v3.sk>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-serial <linux-serial@vger.kernel.org>
Subject: Re: [PATCH 2/4] serial: 8250: export serial8250_get_baud_rate()
Date: Fri, 10 Jul 2026 11:19:38 +0300 (EEST) [thread overview]
Message-ID: <25725cc4-f3c9-8153-b400-c36a5099340a@linux.intel.com> (raw)
In-Reply-To: <20260709205656.319531-3-ansuelsmth@gmail.com>
On Thu, 9 Jul 2026, Christian Marangi wrote:
> Some driver might need to access the current baud rate to correctly
> configure it.
>
> Export the serial8250_get_baud_rate() function to limit code duplication.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> drivers/tty/serial/8250/8250_port.c | 7 ++++---
> include/linux/serial_8250.h | 4 ++++
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
> index 630deb7dd344..033d8fb8bb23 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -2560,9 +2560,9 @@ static void serial8250_set_divisor(struct uart_port *port, unsigned int baud,
> serial8250_do_set_divisor(port, baud, quot);
> }
>
> -static unsigned int serial8250_get_baud_rate(struct uart_port *port,
> - struct ktermios *termios,
> - const struct ktermios *old)
> +unsigned int serial8250_get_baud_rate(struct uart_port *port,
> + struct ktermios *termios,
> + const struct ktermios *old)
> {
> unsigned int tolerance = port->uartclk / 100;
> unsigned int min;
> @@ -2589,6 +2589,7 @@ static unsigned int serial8250_get_baud_rate(struct uart_port *port,
> */
> return uart_get_baud_rate(port, termios, old, min, max);
> }
> +EXPORT_SYMBOL_GPL(serial8250_get_baud_rate);
Please put newly exported things into SERIAL_8250 namespace.
--
i.
next prev parent reply other threads:[~2026-07-10 8:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 20:56 [PATCH 0/4] serial: 8250: Add AN7581 UART support Christian Marangi
2026-07-09 20:56 ` [PATCH 1/4] dt-bindings: serial: 8250: Add Airoha compatibles Christian Marangi
2026-07-10 16:43 ` Conor Dooley
2026-07-09 20:56 ` [PATCH 2/4] serial: 8250: export serial8250_get_baud_rate() Christian Marangi
2026-07-09 21:35 ` Andy Shevchenko
2026-07-09 21:39 ` Christian Marangi
2026-07-10 8:20 ` Andy Shevchenko
2026-07-10 8:49 ` Christian Marangi
2026-07-10 9:14 ` Andy Shevchenko
2026-07-10 8:19 ` Ilpo Järvinen [this message]
2026-07-09 20:56 ` [PATCH 3/4] serial: 8250: map UAPI port type to internal enum Christian Marangi
2026-07-09 21:37 ` Andy Shevchenko
2026-07-09 21:46 ` Christian Marangi
2026-07-10 10:09 ` Andy Shevchenko
2026-07-09 20:56 ` [PATCH 4/4] serial: 8250: Add Airoha SoC UART and HSUART support Christian Marangi
2026-07-10 7:13 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25725cc4-f3c9-8153-b400-c36a5099340a@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ansuelsmth@gmail.com \
--cc=benjamin.larsson@genexis.eu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eg@keba.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiaxun.yang@flygoat.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=lukas@wunner.de \
--cc=m.felsch@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=rongrong@oss.cipunited.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox