Re: [PATCH v3 7/8] mikrobus: Add mikrobus driver

kernel test robot
2024-03-16T09:00:52Z

Hi Ayush,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 61996c073c9b070922ad3a36c981ca6ddbea19a5]

url: https://github.com/intel-lab-lkp/linux/commits/Ayush-Singh/dt-bindings-misc-Add-mikrobus-connector/20240316-025407
base: 61996c073c9b070922ad3a36c981ca6ddbea19a5
patch link: https://lore.kernel.org/r/20240315184908.500352-8-ayushdevel1325%40gmail.com
patch subject: [PATCH v3 7/8] mikrobus: Add mikrobus driver
config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240316/202403161645.CxE8k6qy-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 8f68022f8e6e54d1aeae4ed301f5a015963089b7)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240316/202403161645.CxE8k6qy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403161645.CxE8k6qy-lkp@intel.com/

All warnings (new ones prefixed by >>):

In file included from drivers/misc/mikrobus/mikrobus_id.c:17:
In file included from drivers/misc/mikrobus/mikrobus_core.h:14:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
547 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from drivers/misc/mikrobus/mikrobus_id.c:17:
In file included from drivers/misc/mikrobus/mikrobus_core.h:14:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from drivers/misc/mikrobus/mikrobus_id.c:17:
In file included from drivers/misc/mikrobus/mikrobus_core.h:14:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:26:
In file included from include/linux/kernel_stat.h:9:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:13:
In file included from arch/hexagon/include/asm/io.h:328:
include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
584 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
In file included from drivers/misc/mikrobus/mikrobus_id.c:17:
In file included from drivers/misc/mikrobus/mikrobus_core.h:14:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:21:
In file included from include/linux/mm.h:2208:
include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/misc/mikrobus/mikrobus_id.c:45:60: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
45 | pr_info("mikrobus_id: writing manifest size = %lu bytes", count);
| ~~~ ^~~~~
| %zu
include/linux/printk.h:530:34: note: expanded from macro 'pr_info'
530 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/printk.h:457:60: note: expanded from macro 'printk'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ~~~ ^~~~~~~~~~~
include/linux/printk.h:429:19: note: expanded from macro 'printk_index_wrap'
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ~~~~ ^~~~~~~~~~~
8 warnings generated.

vim +45 drivers/misc/mikrobus/mikrobus_id.c

28
29 static ssize_t mikrobus_manifest_store(struct device *device, struct device_attribute *attr,
30 const char *buf, size_t count)
31 {
32 u8 write_request[] = { W1_MIKROBUS_ID_WRITE_EEPROM,
33 W1_MIKROBUS_EEPROM_MANIFEST_START_PAGE };
34 u8 release_command = W1_MIKROBUS_ID_RELEASE_EEPROM;
35 struct w1_slave *sl = dev_to_w1_slave(device);
36 u16 crc, crc_read, pos = 0;
37 u8 status = 0;
38 int cnt;
39
40 if (count > W1_MIKROBUS_ID_EEPROM_SIZE)
41 return -ENOMEM;
42
43 mutex_lock(&sl->master->bus_mutex);
44
> 45 pr_info("mikrobus_id: writing manifest size = %lu bytes", count);
46 while (pos < count) {
47 if (w1_reset_select_slave(sl))
48 break;
49
50 w1_write_block(sl->master, write_request, sizeof(write_request));
51 crc = crc16(0, write_request, sizeof(write_request)) ^ 0xFFFF;
52 w1_read_block(sl->master, (u8 *)&crc_read, sizeof(crc_read));
53
54 if (crc != crc_read)
55 break;
56
57 for (cnt = 0; cnt < W1_MIKROBUS_ID_EEPROM_PAGE_SIZE; cnt++)
58 w1_write_8(sl->master, (u8)buf[cnt]);
59
60 crc = crc16(0, buf, W1_MIKROBUS_ID_EEPROM_PAGE_SIZE) ^ 0xFFFF;
61 usleep_range(1 * USEC_PER_MSEC, 2 * USEC_PER_MSEC);
62 w1_read_block(sl->master, (u8 *)&crc_read, sizeof(crc_read));
63
64 if (crc != crc_read)
65 break;
66
67 w1_write_8(sl->master, release_command);
68 usleep_range(10 * USEC_PER_MSEC, 15 * USEC_PER_MSEC);
69 status = w1_read_8(sl->master);
70 w1_read_block(sl->master, (u8 *)&crc_read, sizeof(crc_read));
71 crc = crc16(0, (u8 *)&release_command, sizeof(release_command)) ^ 0xFFFF;
72
73 if (status != W1_MIKROBUS_ID_RELEASE_EEPROM)
74 break;
75
76 if (crc != crc_read)
77 break;
78
79 buf += W1_MIKROBUS_ID_EEPROM_PAGE_SIZE;
80 pos += W1_MIKROBUS_ID_EEPROM_PAGE_SIZE;
81 write_request[1]++;
82 }
83
84 pr_info("mikrobus_id: manifest written bytes: %d", pos);
85 mutex_unlock(&sl->master->bus_mutex);
86
87 return count > pos ? count : pos;
88 }
89 static DEVICE_ATTR_WO(mikrobus_manifest);
90

--
0-DAY CI Kernel Test Service