From: Nish Aravamudan <nish.aravamudan@gmail.com>
To: Wen Xiong <wendyx@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [ patch 6/7] drivers/serial/jsm: new serial device driver
Date: Sun, 27 Feb 2005 17:45:06 -0800 [thread overview]
Message-ID: <29495f1d05022717454bc81cfa@mail.gmail.com> (raw)
In-Reply-To: <42225A64.6070904@us.ltcfwd.linux.ibm.com>
> diff -Nuar linux-2.6.9.orig/drivers/serial/jsm/jsm_driver.h linux-2.6.9.new/drivers/serial/jsm/jsm_driver.h
> --- linux-2.6.9.orig/drivers/serial/jsm/jsm_driver.h 1969-12-31 18:00:00.000000000 -0600
> +++ linux-2.6.9.new/drivers/serial/jsm/jsm_driver.h 2005-02-27 17:14:44.747952016 -0600
<snip>
> +#define jsm_jiffies_from_ms(a) (((a) * HZ) / 1000)
Please use the existing msecs_to_jiffies(), which has both a more
sensible name and is correct.
Thanks,
Nish
next prev parent reply other threads:[~2005-02-28 1:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-27 23:40 [ patch 6/7] drivers/serial/jsm: new serial device driver Wen Xiong
2005-02-28 0:47 ` Jeff Garzik
2005-02-28 3:22 ` Christoph Hellwig
2005-02-28 0:56 ` Rik van Riel
2005-02-28 1:45 ` Nish Aravamudan [this message]
2005-02-28 6:55 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29495f1d05022717454bc81cfa@mail.gmail.com \
--to=nish.aravamudan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=wendyx@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).