From: Oliver Giles <ohw.giles@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Jiri Slaby" <jirislaby@kernel.org>,
"Ahelenia Ziemiańska" <nabijaczleweli@nabijaczleweli.xyz>,
"Jens Axboe" <axboe@kernel.dk>,
"Christian Brauner" <brauner@kernel.org>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 08/11] tty: splice_read: disable
Date: Thu, 04 Jan 2024 10:34:14 +1300 [thread overview]
Message-ID: <2XFP6S.GINKQ8IKAA1W1@gmail.com> (raw)
In-Reply-To: <CAHk-=wgLZXULo7pg=nwUMFLsKNUe+1_X=Fk7+f-J0735Oir97w@mail.gmail.com>
On Wed, Jan 3 2024 at 11:14:59 -08:00:00, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> It's some annoying SSL VPN thing that splices to pppd:
>
> https://lore.kernel.org/all/C8KER7U60WXE.25UFD8RE6QZQK@oguc/
I'm happy to report that that particular SSL VPN tool is no longer
around.
And it had anyway grown a fall-back-to-read/write in case splice()
fails.
So at least from my perspective, no objections to splice-to-tty going
away
altogether.
> and I'd be happy to try to limit splice to tty's to maybe just the one
> case that pppd uses.
To be exact, pppd is just providing a pty with which other (now all
extinct?)
applications can do nefarious things.
> Maybe that VPN thing already has the pty in non-blocking mode, for
> example, and we could make the tty splicing fail for any blocking op?
FWIW, the SSL VPN tool did indeed have the pty in non-blocking mode.
Oliver
next prev parent reply other threads:[~2024-01-03 21:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 3:08 [PATCH v2 00/11] Avoid unprivileged splice(file->)/(->socket) pipe exclusion Ahelenia Ziemiańska
2023-12-21 3:09 ` [PATCH v2 08/11] tty: splice_read: disable Ahelenia Ziemiańska
2023-12-21 8:10 ` Greg Kroah-Hartman
2024-01-03 11:36 ` Jiri Slaby
2024-01-03 19:14 ` Linus Torvalds
2024-01-03 21:34 ` Oliver Giles [this message]
2024-01-03 21:57 ` Linus Torvalds
2023-12-24 5:01 ` [PATCH v2 13/11] tty: splice_write: disable Ahelenia Ziemiańska
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2XFP6S.GINKQ8IKAA1W1@gmail.com \
--to=ohw.giles@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox