From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
joel@jms.id.au, andrew@aj.id.au,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
LKML <linux-kernel@vger.kernel.org>,
openbmc@lists.ozlabs.org
Subject: Re: [PATCH 3/4] serial: 8250: Add Aspeed UART driver
Date: Fri, 10 Feb 2023 15:52:03 +0200 (EET) [thread overview]
Message-ID: <2d389fc9-0d5-42a1-b6d7-695c70dcf0fe@linux.intel.com> (raw)
In-Reply-To: <20230210072643.2772-4-chiawei_wang@aspeedtech.com>
On Fri, 10 Feb 2023, Chia-Wei Wang wrote:
> Add the driver for Aspeed UART/VUART devices, which are 16550A
> compatible. It is an wrapper to cover the generic 16550A operation
> while exetending DMA feature for the devices.
>
> Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> ---
> drivers/tty/serial/8250/8250_aspeed.c | 502 ++++++++++++++++++++++++++
> drivers/tty/serial/8250/Kconfig | 8 +
> drivers/tty/serial/8250/Makefile | 1 +
Hi,
Before I look any further into this, could you please explain why this is
made to be entirely separate from what we have in
drivers/tty/serial/8250/8250_aspeed_vuart.c
?
I quickly went through some functions and they've significant parts in
common with no variations at all in many functions and you're defines
are 1:1 too (except for the DMA buf sizes). It would seem much better to
add the missing functionality into 8250_aspeed_vuart.c rather than
creating something from scratch with large overlap with existing code.
If you intend to keep it as a separate one, you should have a rather good
justification for it.
--
i.
next prev parent reply other threads:[~2023-02-10 13:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 7:26 [PATCH 0/4] arm: aspeed: Add UART with DMA support Chia-Wei Wang
2023-02-10 7:26 ` [PATCH 1/4] dt-bindings: aspeed: Add UART controller Chia-Wei Wang
2023-02-10 9:12 ` Krzysztof Kozlowski
2023-02-13 1:57 ` ChiaWei Wang
2023-02-13 8:26 ` Krzysztof Kozlowski
2023-02-13 8:33 ` Krzysztof Kozlowski
2023-02-10 7:26 ` [PATCH 2/4] soc: aspeed: Add UART DMA support Chia-Wei Wang
2023-02-10 9:13 ` Krzysztof Kozlowski
2023-02-13 1:50 ` ChiaWei Wang
2023-02-13 8:31 ` Krzysztof Kozlowski
2023-02-10 10:00 ` kernel test robot
2023-02-10 7:26 ` [PATCH 3/4] serial: 8250: Add Aspeed UART driver Chia-Wei Wang
2023-02-10 10:35 ` Paul Menzel
2023-02-10 13:40 ` Ilpo Järvinen
2023-02-13 4:18 ` ChiaWei Wang
2023-02-10 13:52 ` Ilpo Järvinen [this message]
2023-02-13 1:45 ` ChiaWei Wang
2023-02-13 8:54 ` Ilpo Järvinen
2023-02-10 7:26 ` [PATCH 4/4] ARM: dts: aspeed-g6: Add UDMA node Chia-Wei Wang
2023-02-10 9:14 ` Krzysztof Kozlowski
2023-02-13 1:46 ` ChiaWei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d389fc9-0d5-42a1-b6d7-695c70dcf0fe@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=chiawei_wang@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).