From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Thierry Reding <thierry.reding@kernel.org>
Cc: Frank.Li@oss.nxp.com,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Russell King" <linux@armlinux.org.uk>,
"Richard Genoud" <richard.genoud@bootlin.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Laxman Dewangan" <ldewangan@nvidia.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Cunhao Lu" <1579567540@qq.com>,
"Raul E Rangel" <rrangel@chromium.org>,
"Yenchia Chen" <yenchia.chen@mediatek.com>,
"Zhiyong Tao" <zhiyong.tao@mediatek.com>,
"Carlo Caione" <ccaione@baylibre.com>,
"Moteen Shah" <m-shah@ti.com>, "Kendall Willis" <k-willis@ti.com>,
"Kartik Rajput" <kkartik@nvidia.com>,
"Fan Wu" <fanwu01@zju.edu.cn>,
"Nicolai Buchwitz" <nb@tipi-net.de>,
"Karl Mehltretter" <kmehltretter@gmail.com>,
"Stefan Dösinger" <stefandoesinger@gmail.com>,
"Shitalkumar Gandhi" <shital.gandhi45@gmail.com>,
"Peng Fan" <peng.fan@nxp.com>, "Sherry Sun" <sherry.sun@nxp.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Pan Chuang" <panchuang@vivo.com>,
"Petr Mladek" <pmladek@suse.com>,
"Robin Gong" <yibin.gong@nxp.com>,
"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
"Stephan Gerhold" <stephan.gerhold@linaro.org>,
"Zhaoyang Yu" <2426767509@qq.com>,
"Nikola Z. Ivanov" <zlatistiv@gmail.com>,
"Haoxiang Li" <haoxiang_li2024@163.com>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Myeonghun Pak" <mhun512@gmail.com>,
"Wenhua Lin" <Wenhua.Lin@unisoc.com>,
"Cixi Geng" <cixi.geng@linux.dev>,
"open list:TTY LAYER AND SERIAL DRIVERS"
<linux-kernel@vger.kernel.org>,
"open list:TTY LAYER AND SERIAL DRIVERS"
<linux-serial@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:ARM/FREESCALE IMX / MXC / LAYERSCAPE ARM ARCHIT..."
<imx@lists.linux.dev>,
"open list:ARM/QUALCOMM MAILING LIST"
<linux-arm-msm@vger.kernel.org>,
"open list:ARM/SAMSUNG S3C,
S5P AND EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>,
"open list:TEGRA ARCHITECTURE SUPPORT"
<linux-tegra@vger.kernel.org>,
"moderated list:ARM/STM32 ARCHITECTURE"
<linux-stm32@st-md-mailman.stormreply.com>,
vkoul@kernel.org
Subject: Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback()
Date: Thu, 5 Nov 2026 15:35:20 +0100 [thread overview]
Message-ID: <2e12316d-d079-471f-9c29-ef5fb765216a@kernel.org> (raw)
In-Reply-To: <auyQEVmA2KeGu9DL@ashevche-desk.local>
On 05/11/2026 15:17, Andy Shevchenko wrote:
>>> ---
>>> drivers/tty/serial/8250/8250_dma.c | 6 ++----
>>> drivers/tty/serial/8250/8250_mtk.c | 3 +--
>>> drivers/tty/serial/8250/8250_omap.c | 6 ++----
>>> drivers/tty/serial/amba-pl011.c | 6 ++----
>>> drivers/tty/serial/atmel_serial.c | 6 ++----
>>> drivers/tty/serial/fsl_lpuart.c | 6 ++----
>>> drivers/tty/serial/imx.c | 6 ++----
>>> drivers/tty/serial/msm_serial.c | 6 ++----
>>> drivers/tty/serial/mxs-auart.c | 6 ++----
>>> drivers/tty/serial/pch_uart.c | 6 ++----
>>> drivers/tty/serial/samsung_tty.c | 6 ++----
>>> drivers/tty/serial/serial-tegra.c | 6 ++----
>>> drivers/tty/serial/sh-sci.c | 9 +++------
>>> drivers/tty/serial/sprd_serial.c | 3 +--
>>> drivers/tty/serial/stm32-usart.c | 6 ++----
>>> 15 files changed, 29 insertions(+), 58 deletions(-)
>>
>> Reviewed-by: Thierry Reding <treding@nvidia.com>
>
> Krzysztof, now look at this case. I would argue that this is even less fit than
> # subpart(s) case, because it might imply anything. Again the problem is the
> bundle, and for such a case (when tons of independent changes are bundled in
> the same stuff, *every* Rb tag has to be explained on what has been reviewed!
I think this case is obvious - Thierry reviewed this patch and gives Rb
tag, according to reviewer's statement of oversight. I don't see a
problem here or what is questionable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-05 14:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 17:54 [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback() Frank.Li
2026-11-02 18:10 ` sashiko-bot
2026-11-03 11:39 ` Nicolai Buchwitz
2026-11-04 17:41 ` Krzysztof Kozlowski
2026-11-04 20:29 ` Andy Shevchenko
2026-11-05 9:06 ` Geert Uytterhoeven
2026-11-05 9:17 ` Krzysztof Kozlowski
2026-11-05 9:29 ` Andy Shevchenko
2026-11-05 9:08 ` Geert Uytterhoeven
2026-11-05 12:28 ` Thierry Reding
2026-11-05 14:17 ` Andy Shevchenko
2026-11-05 14:35 ` Krzysztof Kozlowski [this message]
2026-11-05 15:34 ` Thierry Reding
2026-11-05 16:16 ` Andy Shevchenko
2026-11-05 16:18 ` Krzysztof Kozlowski
2026-11-05 16:20 ` Andy Shevchenko
2026-11-05 16:26 ` Krzysztof Kozlowski
2026-11-05 17:59 ` Andy Shevchenko
2026-11-05 15:36 ` Thierry Reding
2026-11-05 16:18 ` Andy Shevchenko
2026-11-05 16:21 ` Krzysztof Kozlowski
2026-11-05 18:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e12316d-d079-471f-9c29-ef5fb765216a@kernel.org \
--to=krzk@kernel.org \
--cc=1579567540@qq.com \
--cc=2426767509@qq.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.Li@oss.nxp.com \
--cc=Wenhua.Lin@unisoc.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=ccaione@baylibre.com \
--cc=cixi.geng@linux.dev \
--cc=claudiu.beznea@tuxon.dev \
--cc=fanwu01@zju.edu.cn \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=haoxiang_li2024@163.com \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=jonathanh@nvidia.com \
--cc=k-willis@ti.com \
--cc=kernel@pengutronix.de \
--cc=kkartik@nvidia.com \
--cc=kmehltretter@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m-shah@ti.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mhun512@gmail.com \
--cc=nb@tipi-net.de \
--cc=nicolas.ferre@microchip.com \
--cc=orsonzhai@gmail.com \
--cc=panchuang@vivo.com \
--cc=peng.fan@nxp.com \
--cc=peter.griffin@linaro.org \
--cc=pmladek@suse.com \
--cc=richard.genoud@bootlin.com \
--cc=rppt@kernel.org \
--cc=rrangel@chromium.org \
--cc=s.hauer@pengutronix.de \
--cc=sherry.sun@nxp.com \
--cc=shital.gandhi45@gmail.com \
--cc=stefandoesinger@gmail.com \
--cc=stephan.gerhold@linaro.org \
--cc=thierry.reding@kernel.org \
--cc=vkoul@kernel.org \
--cc=yenchia.chen@mediatek.com \
--cc=yibin.gong@nxp.com \
--cc=zhang.lyra@gmail.com \
--cc=zhiyong.tao@mediatek.com \
--cc=zlatistiv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox