From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 374E7C4332F for ; Wed, 4 Jan 2023 15:14:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232026AbjADPOn (ORCPT ); Wed, 4 Jan 2023 10:14:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231197AbjADPOl (ORCPT ); Wed, 4 Jan 2023 10:14:41 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C6841AD80; Wed, 4 Jan 2023 07:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672845280; x=1704381280; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version:content-id; bh=QZCwprZw1+mKr5+bFcTpFv2qhvbs1l7/XdAVfCoIPFs=; b=SEWb8UTYJVdEng0I/h37yeXnyehRTINh3OVUjh+Qxi5vCmxykG9KwM0R CYAWGq6L056TrF4xFwYxSLfjsrNPrcOtVqq44HAaXy4KAZWfYW+GMH3YA klR5isnF83F4v16iu9T84tAi/TeqnplFU+OJFifh4M3+E9dDln1WcTsm1 IDFrTHHxWhSNfrCUY31SW3hfVq27lgHbPwGIHFy1hkHujMi4hN/NG6wfN FRNwcfTEwHBPeV2FvXOdCdIablmtkc+BimR4v7xDauyjgw2tyPQEXXj9z LSjgo8UvKJ/qOY3p9iZcyF2CglyRW5sehPohJoTSgFuWiIOj4I5XHuTR9 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="320663935" X-IronPort-AV: E=Sophos;i="5.96,300,1665471600"; d="scan'208";a="320663935" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 07:08:22 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="900578039" X-IronPort-AV: E=Sophos;i="5.96,300,1665471600"; d="scan'208";a="900578039" Received: from msvoboda-mobl.ger.corp.intel.com ([10.252.48.119]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 07:08:19 -0800 Date: Wed, 4 Jan 2023 17:08:10 +0200 (EET) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: lizhe cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial , LKML Subject: Re: [PATCH v3] serial: linflexuart: remove redundant uart type PORT_LINFLEXUART In-Reply-To: <20230104150023.3115-1-sensor1010@163.com> Message-ID: <2f726128-29c-b7dd-ad8-f8b536fbe5f@linux.intel.com> References: <20230104150023.3115-1-sensor1010@163.com> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-339339727-1672844700=:1783" Content-ID: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-339339727-1672844700=:1783 Content-Type: text/plain; CHARSET=ISO-8859-15 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 4 Jan 2023, lizhe wrote: > in linflex_config_port() the member variable type will be > assigned again. see linflex_connfig_port() > > Signed-off-by: lizhe > Acked-by: Jiri Slaby > Acked-by: Ilpo Järvinen Eh, you're not supposed to invent these Acked-by tags yourself. Don't add any tags besides your own unless somebody explicitly gives them to you in a reply! And the subject was supposed to be (as per Jiri's recommendation): serial: linflexuart: remove redundant uart type assignment You also didn't include the history of what was changed in v3. -- i. --8323329-339339727-1672844700=:1783--