From: Dan Carpenter <dan.carpenter@linaro.org>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Alim Akhtar <alim.akhtar@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Thomas Abraham <thomas.abraham@linaro.org>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/2] tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of error
Date: Mon, 12 Jun 2023 07:53:03 +0300 [thread overview]
Message-ID: <30c3b1ae-8df0-4112-bfbb-988d6c8a04e0@kadam.mountain> (raw)
In-Reply-To: <20230610171015.vf7emd5crpr7n4mg@intel.intel>
On Sat, Jun 10, 2023 at 07:10:15PM +0200, Andi Shyti wrote:
> All errors are unlikely and if it's unlikely, why there is no
> unlikely(!rate)?
The likely/unlikely() annotations help performance at the expense of
readability. If they improved readability every if statement would have
them. They should only be used if it makes a difference in a benchmark.
I think I have heard other people say the rule is that they shouldn't be
used in the drivers/ directory.
Also the other thing to consider is that quite often GCC is clever
enough to figure out which paths are success paths and which are failure
paths. So sometimes adding the annotation is redundant.
regards,
dan carpenter
prev parent reply other threads:[~2023-06-12 4:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 4:45 [PATCH 1/2] tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of error Christophe JAILLET
2023-06-09 4:45 ` [PATCH 2/2] tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() when iterating clk Christophe JAILLET
2023-06-09 8:57 ` AW: " Walter Harms
2023-06-09 11:56 ` Krzysztof Kozlowski
2023-06-09 16:17 ` Christophe JAILLET
2023-06-09 11:53 ` Krzysztof Kozlowski
2023-06-10 10:39 ` Andi Shyti
2023-06-10 10:45 ` Krzysztof Kozlowski
2023-06-10 10:57 ` Andi Shyti
2023-06-09 11:51 ` [PATCH 1/2] tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of error Krzysztof Kozlowski
2023-06-10 10:26 ` Andi Shyti
2023-06-10 14:07 ` Christophe JAILLET
2023-06-10 14:54 ` Andi Shyti
2023-06-10 16:23 ` Krzysztof Kozlowski
2023-06-10 17:10 ` Andi Shyti
2023-06-10 17:32 ` Krzysztof Kozlowski
2023-06-10 17:40 ` Christophe JAILLET
2023-06-12 4:53 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30c3b1ae-8df0-4112-bfbb-988d6c8a04e0@kadam.mountain \
--to=dan.carpenter@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox