Re: [PATCH v3 7/8] mikrobus: Add mikrobus driver

Krzysztof Kozlowski
2024-03-19T05:32:57Z

On 16/03/2024 14:06, Ayush Singh wrote:
> > Are you sure this fits in Linux coding style limit (not checkpatch
> limit, but the limit expressed by Linux coding style)?
>
>
> Well, I am just using clang-format with column width of 100 instead of
> 80. The docs now say 80 is prefered rather than mandatory, so well I was

So you introduce your own style? Then consider it mandatory...

> using 100 since I prefer that. If 80 is necessary or would make review
> easier than I can just switch to it.

You do not choose your own coding style.

>
>
> I will remove serdev, pwm, clickID and send a new patch with the minimal
> driver and better commit messages as suggested with Vaishnav. It is
> important to have good support for mikroBUS boards without clickID as well.

Best regards,
Krzysztof