Re: [PATCH 3/4] arm64: dts: mediatek: add device-tree for Genio 720-EVK board

[Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>]

Hi David,

On Thu, 2026-02-19 at 18:09 -0600, David Lechner wrote:
> On 12/3/25 7:59 AM, Louis-Alexis Eyraud wrote:
> > Add support for MediaTek MT8189 SoC and its variants, and a device-
> > tree
> > for the basic hardware enablement of the Genio 720-EVK board, based
> > on
> > MT8391 SoC.
> > 
> > MT8391 SoC is a variant of MT8189 SoC with a difference for the Arm
> > Cortex-A78 CPU core maximum frequency (2.6 Ghz for MT8391, 3 Ghz
> > for
> > MT8189). MT8391 hardware register maps are identical to MT8189.
> > 
> > The Genio 720-EVK board has following features:
> >   - MT8391 SoC
> >   - MT6365 PMIC
> 
> Is MT6365 PMIC ...
> 
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8391-genio-common.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8391-genio-common.dtsi
> > new file mode 100644
> > index
> > 0000000000000000000000000000000000000000..744641916952111a4b389cf6a
> > dbd27c429b6eff2
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/mediatek/mt8391-genio-common.dtsi
> > @@ -0,0 +1,555 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +/*
> > + * Copyright (c) 2025 Collabora Ltd.
> > + * Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
> > + */
> > +
> > +#include "mt6359.dtsi"
> 
> ... really 100% identical to MT6359 PMIC?
> 
I did not find any info in the LKML archives if this topic was
discussed in the past.

The MT6365 PMIC seems to be more a rebranded MT6359P.
They have the exact same buck converter and LDOs, and features.

There are several boards based on MT8370, MT8390 and MT8395 SoC that
integrate the MT6365 PMIC and whose devicetree, present in upstream,
use the mt6359.dtsi for this PMIC support:
 - Mediatek Genio 1200 EVK
 - Mediatek Genio 700 EVK
 - Mediatek Genio 510 EVK
 - Radxa NIO-12L
Probably a couple more.

The Genio 1200 EVK board devicetree was the first one that used
"mediatek,mt6359" compatible for this PMIC.

As far as I know, there is no known compatibility issue.
The MT6359 regulator kernel driver, in particular, does recognise it as
MT6359P (same identifier) and the MT6365 datasheet shows it has the
same register layout from what I compared for the buck and ldos.

So 100% identical? I cannot say it for sure but I don't have any info
telling otherwise.

> Asking because I'm working on this in U-Boot and would be helpful
> to know that this is correct. Would probably be a good idea to
> mention
> it in the commit message too to show this is intentional.
> 
> 
> And I wonder if it would be a good idea to add a compatible with
> fallback
> just to be sure.
> 
> &pmic {
> 	compatible = "mediatek,mt6365", "mediatek,mt6359";
> };

You're right. 
That's make sense to document a proper compatibility in the dt-bindings
and use it the devicetree, not only for pmic node but also but its
subdevices (auxadc, codec, regulator, rtc, pmic-keys).

As the Genio 720 EVK is not the only board concerned, it would be
better that I send another series to do such cleanup, for instance one
that adds a new mt6365.dtsi before using it (instead of mt6359.dtsi) in
the Genio 720 EVK devicetree.

Regards,
Louis-Alexis