From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH] serial: uartps: Add the device_init_wakeup Date: Mon, 17 Dec 2018 16:29:56 +0100 Message-ID: <333f4be8-a4ae-4276-e2ac-725d1ae4c9b0@xilinx.com> References: <20181217151520.GA12453@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181217151520.GA12453@kroah.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Greg Kroah-Hartman , Michal Simek Cc: monstr@monstr.eu, Shubhrajyoti Datta , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org List-Id: linux-serial@vger.kernel.org On 17. 12. 18 16:15, Greg Kroah-Hartman wrote: > On Wed, Dec 05, 2018 at 02:20:11PM +0100, Michal Simek wrote: >> From: Shubhrajyoti Datta >> >> Initialise the device wakeup. > > Why? This says what happened, which you can see from the patch itself, > but it does not say why this is needed at all. We will fix this. > > Also, you sent 4 patches, without any numbering, so I have no idea what > order to apply them in. > > Please fix the changelog entries up and send this as a patch series so > that I can correctly apply them. They are all independent that's why I have sent them separately as single patches. Thanks, Michal