* [PATCH 1/1] tty: Don't include tty_buffer.h tty.h
@ 2024-02-14 14:54 Ilpo Järvinen
2024-02-14 15:16 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Ilpo Järvinen @ 2024-02-14 14:54 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, linux-kernel, linux-serial
Cc: Ilpo Järvinen
There's no need to include linux/tty_buffer.h in linux/tty.h.
Move the include into tty_buffer.c that is actually using it.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
drivers/tty/tty_buffer.c | 1 +
include/linux/tty.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
index f8883afbeeba..79f0ff94ce00 100644
--- a/drivers/tty/tty_buffer.c
+++ b/drivers/tty/tty_buffer.c
@@ -7,6 +7,7 @@
#include <linux/errno.h>
#include <linux/minmax.h>
#include <linux/tty.h>
+#include <linux/tty_buffer.h>
#include <linux/tty_driver.h>
#include <linux/tty_flip.h>
#include <linux/timer.h>
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 8c76fd97d4ad..2b2e6f0a54d6 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -6,7 +6,6 @@
#include <linux/major.h>
#include <linux/termios.h>
#include <linux/workqueue.h>
-#include <linux/tty_buffer.h>
#include <linux/tty_driver.h>
#include <linux/tty_ldisc.h>
#include <linux/tty_port.h>
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] tty: Don't include tty_buffer.h tty.h
2024-02-14 14:54 [PATCH 1/1] tty: Don't include tty_buffer.h tty.h Ilpo Järvinen
@ 2024-02-14 15:16 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2024-02-14 15:16 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jiri Slaby, LKML, linux-serial
[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]
On Wed, 14 Feb 2024, Ilpo Järvinen wrote:
Gah, I seem to have botched the shortlog while I killed linux/ prefixes
from it. I'll send an update tomorrow.
--
i.
> There's no need to include linux/tty_buffer.h in linux/tty.h.
> Move the include into tty_buffer.c that is actually using it.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> drivers/tty/tty_buffer.c | 1 +
> include/linux/tty.h | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
> index f8883afbeeba..79f0ff94ce00 100644
> --- a/drivers/tty/tty_buffer.c
> +++ b/drivers/tty/tty_buffer.c
> @@ -7,6 +7,7 @@
> #include <linux/errno.h>
> #include <linux/minmax.h>
> #include <linux/tty.h>
> +#include <linux/tty_buffer.h>
> #include <linux/tty_driver.h>
> #include <linux/tty_flip.h>
> #include <linux/timer.h>
> diff --git a/include/linux/tty.h b/include/linux/tty.h
> index 8c76fd97d4ad..2b2e6f0a54d6 100644
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -6,7 +6,6 @@
> #include <linux/major.h>
> #include <linux/termios.h>
> #include <linux/workqueue.h>
> -#include <linux/tty_buffer.h>
> #include <linux/tty_driver.h>
> #include <linux/tty_ldisc.h>
> #include <linux/tty_port.h>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-14 15:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-14 14:54 [PATCH 1/1] tty: Don't include tty_buffer.h tty.h Ilpo Järvinen
2024-02-14 15:16 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).