Re: [PATCH 2/3] tty: serial: meson: meson_uart_shutdown omit clear AML_UART_TX_EN bit

Yu Tu
2021-12-22T09:01:04Z

On 2021/12/21 15:32, Greg Kroah-Hartman wrote:
> [ EXTERNAL EMAIL ]
>
> On Tue, Dec 21, 2021 at 03:16:33PM +0800, Yu Tu wrote:
>> The meson_uart_shutdown function should have the opposite operation to
>> the meson_uart_startup function, so the shutdown of AML_UART_TX_EN is
>> logically missing.
>>
>> Signed-off-by: Yu Tu <yu.tu@amlogic.com>
>
> What commit does this fix? Should it go to stable kernels? Please put
> that in here if needed.
>
It has not yet been revealed that this is a bug. The reason I changed it
was because I thought it was an improvement and it might be a hidden
bug.The AML_UART_TX_EN bit is conspicuously missing when comparing the
meson_uart_shutdown and meson_uart_startup functions.So I think it's
best to add.
> thanks,
>
> greg k-h
>