From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Chander Kashyap <chander.kashyap@linaro.org>,
mark.rutland@arm.com, kgene.kim@samsung.com,
linux-serial@vger.kernel.org, t.figa@samsung.com,
linux-samsung-soc@vger.kernel.org, thomas.ab@samsung.com,
s.nawrocki@samsung.com
Subject: Re: [PATCH v3 10/10] ARM: Exynos: extend soft-reset support for Exynos5420
Date: Mon, 17 Jun 2013 14:21:49 +0200 [thread overview]
Message-ID: <3807303.re8cJcYGJh@wuerfel> (raw)
In-Reply-To: <1371466836-4111-11-git-send-email-chander.kashyap@linaro.org>
On Monday 17 June 2013 16:30:35 Chander Kashyap wrote:
> @@ -330,10 +330,10 @@ void exynos5_restart(char mode, const char *cmd)
> u32 val;
> void __iomem *addr;
>
> - if (of_machine_is_compatible("samsung,exynos5250")) {
> - val = 0x1;
> - addr = EXYNOS_SWRESET;
> - } else if (of_machine_is_compatible("samsung,exynos5440")) {
> + val = 0x1;
> + addr = EXYNOS_SWRESET;
> +
> + if (of_machine_is_compatible("samsung,exynos5440")) {
> u32 status;
> np = of_find_compatible_node(NULL, NULL, "samsung,exynos5440-clock");
>
Please try to avoid adding further uses of hardcoded MMIO addresses.
Can you change that to use the same logic that exynos5440 has?
Arnd
next prev parent reply other threads:[~2013-06-17 12:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 11:00 [PATCH v3 00/10] ARM: Exynos: Add Exynos5420 SoC support Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 01/10] ARM: dts: fork out common Exynos5 nodes Chander Kashyap
2013-06-17 11:38 ` Kukjin Kim
2013-06-18 4:24 ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 02/10] ARM: dts: list the CPU nodes for Exynos5250 Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 03/10] ARM: Exynos: Add support for Exynos5420 SoC Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 04/10] serial: samsung: select Exynos specific driver data if ARCH_EXYNOS is defined Chander Kashyap
2013-06-17 11:45 ` Kukjin Kim
2013-06-18 10:31 ` Kukjin Kim
2013-06-18 15:19 ` 'Greg Kroah-Hartman'
2013-06-17 11:00 ` [PATCH v3 05/10] ARM: Exynos: use four additional chipid bits to identify Exynos family Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 06/10] clk: exynos5420: register clocks using common clock framework Chander Kashyap
2013-06-17 11:49 ` Kukjin Kim
2013-06-17 12:27 ` Arnd Bergmann
2013-06-18 4:09 ` Chander Kashyap
2013-06-18 14:01 ` Arnd Bergmann
2013-06-18 14:26 ` Tomasz Figa
2013-06-18 17:13 ` Arnd Bergmann
2013-06-17 11:00 ` [PATCH v3 07/10] ARM: dts: Add initial device tree support for Exynos5420 Chander Kashyap
2013-06-17 11:44 ` Tomasz Figa
2013-06-18 4:21 ` Chander Kashyap
2013-06-18 7:36 ` Tomasz Figa
2013-06-17 11:00 ` [PATCH v3 08/10] clocksource: exynos_mct: use (request/free)_irq calls for local timer registration Chander Kashyap
2013-06-17 11:53 ` Kukjin Kim
2013-06-18 4:11 ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 09/10] ARM: Exynos: add secondary CPU boot base location for Exynos5420 Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 10/10] ARM: Exynos: extend soft-reset support " Chander Kashyap
2013-06-17 12:21 ` Arnd Bergmann [this message]
2013-06-18 4:10 ` Chander Kashyap
2013-06-17 11:45 ` [PATCH v3 00/10] ARM: Exynos: Add Exynos5420 SoC support Tomasz Figa
2013-06-17 11:56 ` Kukjin Kim
2013-06-18 4:28 ` Chander Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3807303.re8cJcYGJh@wuerfel \
--to=arnd@arndb.de \
--cc=chander.kashyap@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=s.nawrocki@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox