From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
Cc: baohua@kernel.org, gregkh@linuxfoundation.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, jslaby@suse.com
Subject: Re: [PATCH] serial: sirf: Simplify a test
Date: Tue, 8 Nov 2016 08:18:04 +0100 [thread overview]
Message-ID: <39a1050e-fb64-a6e5-8939-4e01631e59ea@wanadoo.fr> (raw)
In-Reply-To: <2916662.De1FDumaQl@wuerfel>
Le 07/11/2016 à 14:50, Arnd Bergmann a écrit :
> On Tuesday, November 1, 2016 8:03:33 AM CET Christophe JAILLET wrote:
>> 'dmaengine_prep_dma_cyclic()' does not return an error pointer, so the test
>> can be simplified to be more consistent.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> The change looks correct in principle. It would be good to automate looking
> for other instances of this bug. How did you find it? Do you have e.g. a
> coccinelle script or did you just stumble over the issue by accident?
Hi,
You can have an idea of the strategy used in this post:
https://lkml.org/lkml/2016/11/1/388
Julia is currently working on a more complete strategy in order to find
such issues.
In the meantime, if you want, I can send the coccinelle scripts used.
Best regards,
CJ
next prev parent reply other threads:[~2016-11-08 7:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 7:03 [PATCH] serial: sirf: Simplify a test Christophe JAILLET
2016-11-07 13:50 ` Arnd Bergmann
2016-11-07 17:19 ` Julia Lawall
2016-11-08 7:18 ` Christophe JAILLET [this message]
2016-11-08 11:41 ` Arnd Bergmann
2016-11-10 21:18 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a1050e-fb64-a6e5-8939-4e01631e59ea@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=arnd@arndb.de \
--cc=baohua@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox