public inbox for linux-serial@vger.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Peter Astrand <peter@cendio.se>
Cc: ltsp-discuss@lists.sourceforge.net, d.sbragion@infotecna.it,
	linux-serial@vger.kernel.org
Subject: Re: Serial port redirection
Date: Wed, 03 Dec 2003 07:31:55 -0600	[thread overview]
Message-ID: <3FCDE5CB.4090303@acm.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0312031557190.12826-100000@maggie.lkpg.cendio.se>

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

I've attached a ser2net patch for this.  Could you try it out?

-Corey

Peter Astrand wrote:

>* ser2net is totally incompatible with cyclades-serial-client. This is
>because ser2net interprets RFC2217 a bit differently. sredird sends
>command "101" as ack for command "1", while ser2net sends "1". RFC2217 is
>not very explicit about which way is most correct. The ser2net approach
>looks better to me, but the sredird one is probably more widely used
>(since Cyclades terminal server uses it, for example.) Probably, RFC2217
>software needs to handle both cases.
>
>  
>


[-- Attachment #2: ser2net-com-option.diff --]
[-- Type: text/plain, Size: 2075 bytes --]

? .libs
? Makefile
? Makefile.in
? aclocal.m4
? config.cache
? config.log
? config.status
? configure
? libtool
? ser2net
? .deps/controller.P
? .deps/dataxfer.P
? .deps/devcfg.P
? .deps/readconfig.P
? .deps/selector.P
? .deps/ser2net.P
? .deps/telnet.P
? .deps/utils.P
Index: ChangeLog
===================================================================
RCS file: /cvsroot/ser2net/ser2net/ChangeLog,v
retrieving revision 1.36
diff -u -r1.36 ChangeLog
--- ChangeLog	14 Oct 2003 20:52:13 -0000	1.36
+++ ChangeLog	4 Dec 2003 17:31:04 -0000
@@ -1,4 +1,11 @@
 
+2003-12-04  Corey Minyard <minyard@acm.org>
+
+	* dataxfer.c: Have the telnet option responses use the 1xx
+	responses to the com port control options.  I believe this is
+	wrong, but it is consistent with other products already in the
+	field.
+
 2003-10-14  Corey Minyard <minyard@acm.org>
 
 	* configure.in: Moved to version 2.0.
Index: dataxfer.c
===================================================================
RCS file: /cvsroot/ser2net/ser2net/dataxfer.c,v
retrieving revision 1.28
diff -u -r1.28 dataxfer.c
--- dataxfer.c	14 Oct 2003 20:52:13 -0000	1.28
+++ dataxfer.c	4 Dec 2003 17:31:04 -0000
@@ -2000,7 +2000,7 @@
 	}
 	get_rate_from_baud_rate(val, &val);
 	outopt[0] = 44;
-	outopt[1] = 1;
+	outopt[1] = 101;
 	*((uint32_t *) (outopt+2)) = htonl(val);
 	telnet_send_option(&port->tn_data, outopt, 6);
 	break;
@@ -2030,7 +2030,7 @@
 	    }
 	}
 	outopt[0] = 44;
-	outopt[1] = 2;
+	outopt[1] = 102;
 	outopt[2] = val;
 	telnet_send_option(&port->tn_data, outopt, 3);
 	break;
@@ -2061,7 +2061,7 @@
 		val = 1; /* NONE */
 	}
 	outopt[0] = 44;
-	outopt[1] = 3;
+	outopt[1] = 103;
 	outopt[2] = val;
 	telnet_send_option(&port->tn_data, outopt, 3);
 	break;
@@ -2088,7 +2088,7 @@
 		val = 1; /* 1 stop bit. */
 	}
 	outopt[0] = 44;
-	outopt[1] = 4;
+	outopt[1] = 104;
 	outopt[2] = val;
 	telnet_send_option(&port->tn_data, outopt, 3);
 	break;
@@ -2210,7 +2210,7 @@
 	}
 
 	outopt[0] = 44;
-	outopt[1] = 5;
+	outopt[1] = 105;
 	outopt[2] = val;
 	telnet_send_option(&port->tn_data, outopt, 3);
 	break;

  reply	other threads:[~2003-12-04 17:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-01 14:32 Serial port redirection Peter Astrand
     [not found] ` <Pine.LNX.4.44.0312011300480.8142-100000-K9BqGu7AvB3wj5YHdwD3Ga2PxDmRETKR@public.gmane.org>
2003-12-03 16:30   ` Peter Astrand
2003-12-03 13:31     ` Corey Minyard [this message]
2003-12-05  9:11       ` Peter Astrand
2003-12-05 21:10         ` Corey Minyard
2003-12-08  9:49           ` Peter Astrand
2003-12-08 10:11             ` Peter Astrand
     [not found]     ` <Pine.LNX.4.44.0312031557190.12826-100000-K9BqGu7AvB3wj5YHdwD3Ga2PxDmRETKR@public.gmane.org>
2003-12-03 16:36       ` Jeffrey Altman
     [not found]         ` <3FCE1101.40502-WLbs8XpHrcb2fBVCVOL8/A@public.gmane.org>
2003-12-03 13:02           ` Corey Minyard
     [not found]             ` <3FCDDEE6.4070905-HInyCGIudOg@public.gmane.org>
2003-12-04 17:13               ` Jeffrey Altman
     [not found]                 ` <3FCF6B4D.2050103-WLbs8XpHrcb2fBVCVOL8/A@public.gmane.org>
2003-12-03 13:23                   ` Corey Minyard
2003-12-04 17:37                     ` Jeffrey Altman
2003-12-04 17:49                       ` Corey Minyard
     [not found]                         ` <3FCF73BE.1010707-HInyCGIudOg@public.gmane.org>
2003-12-04 19:12                           ` Jeffrey Altman
2003-12-03 16:42       ` Jeffrey Altman
2003-12-03 13:21         ` Corey Minyard
2003-12-04 17:34           ` Jeffrey Altman
     [not found]             ` <3FCF7026.6070109-WLbs8XpHrcb2fBVCVOL8/A@public.gmane.org>
2003-12-03 13:45               ` Corey Minyard
2003-12-04 17:52                 ` Jeffrey Altman
2003-12-05  9:19             ` Peter Astrand
2003-12-05 15:33               ` Jeffrey Altman
2003-12-05 15:43                 ` Peter Astrand
2003-12-05 15:50                   ` Jeffrey Altman
2003-12-06 23:31                     ` Peter Astrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FCDE5CB.4090303@acm.org \
    --to=minyard@acm.org \
    --cc=d.sbragion@infotecna.it \
    --cc=linux-serial@vger.kernel.org \
    --cc=ltsp-discuss@lists.sourceforge.net \
    --cc=peter@cendio.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox