From: Jiri Slaby <jirislaby@kernel.org>
To: Tom Rix <trix@redhat.com>,
gregkh@linuxfoundation.org, sherry.sun@nxp.com,
jindong.yue@nxp.com
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "tty: serial: fsl_lpuart: adjust SERIAL_FSL_LPUART_CONSOLE config dependency"
Date: Tue, 28 Feb 2023 07:24:18 +0100 [thread overview]
Message-ID: <3cab55f8-b8b8-d244-3c27-a3f84286020e@kernel.org> (raw)
In-Reply-To: <20230226173846.236691-1-trix@redhat.com>
On 26. 02. 23, 18:38, Tom Rix wrote:
> This reverts commit 5779a072c248db7a40cfd0f5ea958097fd1d9a30.
>
> This results in a link error of
>
> ld: drivers/tty/serial/earlycon.o: in function `parse_options':
> drivers/tty/serial/earlycon.c:99: undefined reference to `uart_parse_earlycon'
>
> When the config is in this state
>
> CONFIG_SERIAL_CORE=m
> CONFIG_SERIAL_CORE_CONSOLE=y
> CONFIG_SERIAL_EARLYCON=y
> CONFIG_SERIAL_FSL_LPUART=m
> CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
>
> Fixes: 5779a072c248 ("tty: serial: fsl_lpuart: adjust SERIAL_FSL_LPUART_CONSOLE config dependency")
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Jiri Slaby <jirislaby@kernel.org>
thanks,
--
js
suse labs
prev parent reply other threads:[~2023-02-28 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-26 17:38 [PATCH] Revert "tty: serial: fsl_lpuart: adjust SERIAL_FSL_LPUART_CONSOLE config dependency" Tom Rix
2023-02-26 22:45 ` Randy Dunlap
2023-02-28 6:24 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cab55f8-b8b8-d244-3c27-a3f84286020e@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jindong.yue@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sherry.sun@nxp.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox