From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: serial: samsung: Remove superfluous braces in macro
Date: Fri, 2 Feb 2024 16:32:41 +0100 [thread overview]
Message-ID: <3cf997d1-e178-4162-a5b7-4c2a3ddeffd6@linaro.org> (raw)
In-Reply-To: <CAPLW+4nPnPywwsjkeJE70GzyBL=smEo5_=0usGwmnaPRgZwdrQ@mail.gmail.com>
On 02/02/2024 15:54, Sam Protsenko wrote:
> On Fri, Feb 2, 2024 at 1:49 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 02/02/2024 02:05, Sam Protsenko wrote:
>>> Commit 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
>>> removes parameters from EXYNOS_COMMON_SERIAL_DRV_DATA() macro, but
>>> leaves unnecessary empty braces. Remove those to fix the style. No
>>> functional change.
>>>
>>> Fixes: 59f37b7370ef ("tty: serial: samsung: Remove USI initialization")
>>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
>>> ---
>>> drivers/tty/serial/samsung_tty.c | 8 ++++----
>>
>> I am pretty sure you did the patch on some old tree, not mainline rc1.
>> Please work on maintainers tree (or linux-next).
>>
>
> Hi Krzysztof,
>
> I worked on linux-next, and rebased it on top of the latest linux-next
> yesterday, right before submitting. I distinctly remember solving a
> conflict while rebasing, due to the new commit 0b87a9fd670a ("tty:
> serial: samsung: set UPIO_MEM32 iotype for gs101") which just got into
> linux-next yesterday. Please let me know if you want me to rebase it
> on another tree and re-submit.
>
Hmm... Almost two months ago GS101 was applied which also uses
EXYNOS_COMMON_SERIAL_DRV_DATA, so should be in the hunks here, but
maybye it's gone now?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-02 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 1:05 [PATCH] tty: serial: samsung: Remove superfluous braces in macro Sam Protsenko
2024-02-02 7:49 ` Krzysztof Kozlowski
2024-02-02 14:54 ` Sam Protsenko
2024-02-02 15:32 ` Krzysztof Kozlowski [this message]
2024-02-02 15:34 ` Krzysztof Kozlowski
2024-02-06 14:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cf997d1-e178-4162-a5b7-4c2a3ddeffd6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox