From: Roman Kurakin <rik@cronyx.ru>
To: Harald Welte <laforge@gnumonks.org>
Cc: rmk+serial@arm.linux.org.uk, linux-serial@vger.kernel.org
Subject: Re: Fix supprot for AFAVLAB 8port boards in 2.6.x
Date: Fri, 05 Mar 2004 17:15:01 +0300 [thread overview]
Message-ID: <40488B65.904@cronyx.ru> (raw)
In-Reply-To: <20040305112404.GJ1105@sunbeam.de.gnumonks.org>
May be you didn't add support of more than four ports?
Best regards,
Roman Kurakin
Harald Welte wrote:
>Hi!
>
>I didn't yet use one of my AFAVLAB boards with 2.6.x until now. The
>upper 4 ports are not detected at all. I suppose the bug was introduced
>while porting the driver from 2.4.x.
>
>Please consider applying the following patch. It also adds support for
>a new 8port board called P030.
>
>Thanks,
>
>
>diff -Nru --exclude-from /sunbeam/home/laforge/scripts/dontdiff linuxppc25bh-040218-test/drivers/pci/pci.ids linuxppc25bh-040218-serial/drivers/pci/pci.ids
>--- linuxppc25bh-040218-test/drivers/pci/pci.ids 2004-02-16 09:43:49.000000000 +0100
>+++ linuxppc25bh-040218-serial/drivers/pci/pci.ids 2004-03-05 12:10:09.685724629 +0100
>@@ -5601,6 +5601,8 @@
> 14da National Aerospace Laboratories
> 14db AFAVLAB Technology Inc
> 2120 TK9902
>+ 2180 P028
>+ 2182 P030
> 14dc Amplicon Liveline Ltd
> 0000 PCI230
> 0001 PCI242
>diff -Nru --exclude-from /sunbeam/home/laforge/scripts/dontdiff linuxppc25bh-040218-test/drivers/serial/8250_pci.c linuxppc25bh-040218-serial/drivers/serial/8250_pci.c
>--- linuxppc25bh-040218-test/drivers/serial/8250_pci.c 2004-02-16 09:44:28.000000000 +0100
>+++ linuxppc25bh-040218-serial/drivers/serial/8250_pci.c 2004-03-05 12:23:02.331325424 +0100
>@@ -141,13 +141,15 @@
> struct serial_struct *req, int idx)
> {
> unsigned int bar, offset = board->first_offset;
>
> bar = FL_GET_BASE(board->flags);
> if (idx < 4)
> bar += idx;
>- else
>+ else {
>+ bar = 4;
> offset += (idx - 4) * board->uart_offset;
>+ }
>
> return setup_port(dev, req, bar, offset, board->reg_shift);
> }
>
>@@ -1891,6 +1895,9 @@
> { PCI_VENDOR_ID_AFAVLAB, PCI_DEVICE_ID_AFAVLAB_P028,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> pbn_b0_bt_8_115200 },
>+ { PCI_VENDOR_ID_AFAVLAB, PCI_DEVICE_ID_AFAVLAB_P030,
>+ PCI_ANY_ID, PCI_ANY_ID, 0, 0,
>+ pbn_b0_bt_8_115200 },
>
> { PCI_VENDOR_ID_LAVA, PCI_DEVICE_ID_LAVA_DSERIAL,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0,
>
>
next prev parent reply other threads:[~2004-03-05 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-05 11:24 Fix supprot for AFAVLAB 8port boards in 2.6.x Harald Welte
2004-03-05 14:15 ` Roman Kurakin [this message]
2004-03-05 14:13 ` Harald Welte
2004-03-05 20:38 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40488B65.904@cronyx.ru \
--to=rik@cronyx.ru \
--cc=laforge@gnumonks.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).