From: skakit@codeaurora.org
To: Greg KH <gregkh@linuxfoundation.org>
Cc: swboyd@chromium.org, mgautam@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
akashast@codeaurora.org, rojay@codeaurora.org,
msavaliy@qti.qualcomm.com
Subject: Re: [PATCH V3 2/2] tty: serial: qcom_geni_serial: Fix RX cancel command failure
Date: Fri, 13 Mar 2020 19:23:50 +0530 [thread overview]
Message-ID: <436ae3cfb957b11b0d7aa3b1dbb0adf2@codeaurora.org> (raw)
In-Reply-To: <20200312091041.GA198954@kroah.com>
On 2020-03-12 14:40, Greg KH wrote:
> On Fri, Mar 06, 2020 at 12:17:08PM +0530, satya priya wrote:
>> RX cancel command fails when BT is switched on and off multiple times.
>>
>> To handle this, poll for the cancel bit in SE_GENI_S_IRQ_STATUS
>> register
>> instead of SE_GENI_S_CMD_CTRL_REG.
>>
>> As per the HPG update, handle the RX last bit after cancel command
>> and flush out the RX FIFO buffer.
>>
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> ---
>> drivers/tty/serial/qcom_geni_serial.c | 18 ++++++++++++++----
>> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> This patch didn't apply :(
V1 of this patch is already picked in tty-next tree(commit id:
679aac5ead2f18d223554a52b543e1195e181811). There is no change in this
patch from V1 to V3[2/2].
There is a crash reported by Stephen with V1, to resolve that we posted
next versions adding this patch
https://patchwork.kernel.org/patch/11423231/, that is, V3[1/2]. So now
only V3[1/2] needs to be picked.
next prev parent reply other threads:[~2020-03-13 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 6:47 [PATCH V3 0/2] Fix RX cancel command failure satya priya
2020-03-06 6:47 ` [PATCH V3 1/2] tty: serial: qcom_geni_serial: Allocate port->rx_fifo buffer in probe satya priya
2020-03-06 6:47 ` [PATCH V3 2/2] tty: serial: qcom_geni_serial: Fix RX cancel command failure satya priya
2020-03-09 6:41 ` Stephen Boyd
2020-03-12 9:10 ` Greg KH
2020-03-13 13:53 ` skakit [this message]
2020-03-14 8:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=436ae3cfb957b11b0d7aa3b1dbb0adf2@codeaurora.org \
--to=skakit@codeaurora.org \
--cc=akashast@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mgautam@codeaurora.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=rojay@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).