Re: [PATCH 05/33] powerpc/powermac: remove unneeded tty includes

Ilpo Järvinen
2025-06-11T11:26:06Z

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

On Wed, 11 Jun 2025, Jiri Slaby (SUSE) wrote:

> All these includes must have been cut & pasted. The code does not use
> any tty or vt functionality at all.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: linuxppc-dev@lists.ozlabs.org
> ---
> arch/powerpc/platforms/powermac/setup.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platforms/powermac/setup.c
> index e119ced05d10..eb092f293113 100644
> --- a/arch/powerpc/platforms/powermac/setup.c
> +++ b/arch/powerpc/platforms/powermac/setup.c
> @@ -28,13 +28,11 @@
> #include <linux/ptrace.h>
> #include <linux/export.h>
> #include <linux/user.h>
> -#include <linux/tty.h>
> #include <linux/string.h>
> #include <linux/delay.h>
> #include <linux/ioport.h>
> #include <linux/major.h>
> #include <linux/initrd.h>
> -#include <linux/vt_kern.h>
> #include <linux/console.h>
> #include <linux/pci.h>
> #include <linux/adb.h>

Seems true. I had to actually scan through the file as it does have some
console related setup.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.