From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Hancock Subject: Re: serial flow control appears broken Date: Thu, 02 Aug 2007 11:02:10 -0600 Message-ID: <46B20E12.4020700@shaw.ca> References: <46A84B4A.6070902@shaw.ca> <46A8C6F1.4080309@howardsilvan.com> <46AA2748.80703@howardsilvan.com> <46AA3801.7090204@shaw.ca> <20070728092842.GC26443@flint.arm.linux.org.uk> <46B1F0CB.9060106@rtr.ca> <46B202DE.5000709@shaw.ca> <20070802175711.12bdcaec@the-village.bc.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from shawidc-mo1.cg.shawcable.net ([24.71.223.10]:46306 "EHLO pd3mo2so.prod.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543AbXHBRDN (ORCPT ); Thu, 2 Aug 2007 13:03:13 -0400 In-reply-to: <20070802175711.12bdcaec@the-village.bc.nu> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Alan Cox Cc: Mark Lord , "Maciej W. Rozycki" , Russell King , Lee Howard , linux-serial@vger.kernel.org, tytso@mit.edu, linux-kernel@vger.kernel.org Alan Cox wrote: >> I think that PIO transfers only have to be done with interrupts disabled >> on really old, evil controllers (without unmask set). I don't think >> libata ever disables interrupts during transfers(?) > > Currently libata PIO is mostly done in the IRQ path. Albert Lee was doing > some work on that but its actually very hard to fix without doing polled > PIO. Ah, right. Misread the code.